[codex] refactor workflow executor node handlers#270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors the monolithic
WorkflowExecutor._execute_node_logicnode dispatch into modular per-node handlers underbackend/app/services/node_execution/nodes/.What Changed
NodeExecutionContextand a node handler registry for workflow node execution.WorkflowExecutorresponsible for orchestration, retries, tracing, cancellation, pinned data handling, and finalNodeResultpackaging.AGENTS.mddirective so future node execution logic goes through modular handlers instead of new executor branches.check.shguard that fails fast when tracked frontend/backend text files exceed 10,000 lines.Impact
This reduces the
workflow_executor.pygod-file surface and gives each node type a clear backend home while preserving current runtime behavior and existing patch seams used by tests.Validation
SECRET_KEY=test-secret-key-for-tests-only-32-bytes uv run pytest tests/test_workflow_executor_branching.py tests/test_json_output_mapper_node.py tests/test_mcp_call_node.py tests/test_websocket_node.py tests/test_discord_node.py tests/test_send_email_node.py tests/test_bigquery_node.py tests/test_github_node.py tests/test_drive_node.py tests/test_linear_node.py tests/test_amazon_s3_node.pySECRET_KEY=test-secret-key-for-tests-only-32-bytes ./check.sh./check.sh:1696 passed./run_e2e.sh:66 passed