impl/clickhouse#262
Merged
Merged
Conversation
mbakgun
commented
Jun 27, 2026
Contributor
- Implement ClickHouse node with service, operations, and documentation
…e-click Double-clicking a clickhouse node did nothing because two node-type gates omitted it: selectedNodeHasPrimaryEvaluateExpandTarget() fell through to default:false (routing to the fallback dialog instead of the primary 1/n path), and openPrimaryExpandDialogForSelectedNode() had no clickhouse branch to open the first field. Add both, plus the clickhouse close in closeAllExpressionExpandDialogs(), matching the bigquery/supabase pattern.
Honor user-entered limits exactly and emit no LIMIT clause when limit<=0, matching the Supabase 0=fetch-all semantics. Updates the field label, DSL prompt, and node doc accordingly.
clickhouse-connect returns datetime/Decimal/UUID/IP/bytes and nested containers; node output is serialized with json.dumps downstream, which raised 'Object of type datetime is not JSON serializable'. Normalize all row values at the service boundary (datetime->ISO, Decimal->float, UUID/IP->str, bytes->utf-8, recurse into Array/Tuple/Map).
Each operation created a fresh clickhouse-connect client (~5ms TCP+session setup, measured 6.1ms cold vs 1.0ms warm). Add a process-wide client pool keyed by connection (mirrors grist/qdrant/redis pools), wired into the startup warm-up and shutdown close hooks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.