Merged
Conversation
Use view.lineBlockAt() instead of view.coordsAtPos(). The previous method ddin't work when there was an inline-block widget (e.g. an image) on the first line of a block. The positioning should be identical, but using lineBlockAt() works with inline-blocks on the first line.
…ead of 2px This makes images with 100% width centered.
- Add support for <∞img;...∞> tags that are displayed as image widgets. - Image widgets can be resized - Image tags are excluded when searching - Folding a block with an image on the first row makes sure not to place the fold cutoff point in the middle of the tag - Visible images (on the first row) of folded blocks gets rendered as miniatures
Closed
…he same row as image tags
…atio) when resizing images. * Tweak colors of selected images * Fix issue where resize handle would flicker on mouseup
…pboard data on copy/paste/cut * WIP: Add support for storing images in heynote's file library * When pasting image data, store it in the file library and add an image tag referencing it through heynote-file://image/ * When copying content, serialize it into three formats: text/plain, text/html and "web text/heynote" - For "text/html", <∞img∞> tags are replaced with <img> tags with the image data is a data URL in the src attribute - For "web text/heynote" the data is copied as is * When pasting content of the type "web text/heynote", new UUID IDs are generated for each <∞img∞> tag
…rs when copying/pasting within heynote
Remove image files, that are no longer referenced (and are >24h old), on startup. We use ripgrep to find all <∞img∞> tags in the file library.
…s found in .images/. This should make the code more resilient to potential data loss bugs in the future.
Add tests for FileLibrary
Fix issue with references pointing to the wrong image after recycling of an image widget's DOM elements. Make highlight border for image widgets green when it has snapped to the ideal dimensions.
Try to get e2e tests to work on CI
- Add tests for parsing of image tags - Add tests for ImageWidget
…mediately before or after an image
…y the Clipboard API
…racter for filenames on Windows
Add ripgrep to electron-builder's asarUnpack config so that the ripgrep binary gets unpacked from the built *.asar file, and can be spawned. #build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a work in progress PR that adds support for images.
Fixes #157
Todo:
text/plaindata, as well astext/htmlheynote-library-path/.images/and insert an image widget tag referring to the stored image.images/that has no references (and are older than X days)