Merged
Conversation
heyman
reviewed
Dec 17, 2025
public/langdetect-worker.js
Outdated
| importScripts("guesslang.min.js") | ||
|
|
||
| GUESSLANG_LANGUAGES = ["json","py","html","sql","md","java","php","css","xml","cpp","rs","cs","rb","sh","yaml","toml","go","clj","ex","erl","js","ts","swift","kt","groovy","ps1","dart","scala"] | ||
| GUESSLANG_LANGUAGES = ["json","py","html","sql","md","java","php","css","xml","cpp","rs","cs","rb","sh","yaml","toml","go","clj","ex","erl","js","ts","swift","kt","groovy","ps1","dart","scala", "mermaid"] |
Owner
There was a problem hiding this comment.
Guesslang doesn't support Mermaid, so "mermaid" should not me in this list.
Contributor
|
Should mermaid be its own language, or just supported in Markdown blocks? |
…id is not supported by guesslang
Owner
|
Merged now. Thanks!
The "cost" of adding an additional language is low (i.e. it barely increases the UI surface area, doesn't introduce any new concepts, and it shouldn't affect performance), so I think it's fine having it as a separate block type if that's something that is useful to people. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Mermaid language support(#393)