Repository navigation
fix(cli): check no longer reports GPU stalls from its own pixel reads - #7736
Open
miguel-heygen wants to merge 1 commit into
Open
miguel-heygen wants to merge 1 commit into
miguel-heygen wants to merge 1 commit into
Conversation
… as the film's warnings check copies each canvas into a 2D context to see whether it moved. On WebGL that readback makes Chrome log a GL driver Performance note, which check then listed as a console warning from the composition.
Contributor
Edit accuracy: accurate 267 (base branch 267), smooth 97 of thoseThe gate passes. Quarantined, measured but not gated (8)
Unstable (1)
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
hyperframes checkno longer lists Chrome's "GPU stall due to ReadPixels" notes as warnings from the composition. Check causes them itself.Why
To tell whether a canvas moved, check's motion signature copies each canvas into a 2D context and reads its pixels (
motion-signature.browser.js,drawImagethengetImageData). On a WebGL canvas that readback makes Chrome log a GL driver note such as:Check then reported each one as a
console_warningfrom the film. A WebGL composition that draws only fromhf-seekgot six of them, none caused by its own code, so authors were told to fix something they did not write.Related work
None.
How
wireRuntimeListeners(packages/cli/src/utils/checkBrowser.ts), the one place console output becomes runtime findings, skips warnings that are Chrome GL driver Performance notes ([.WebGL-…]GL Driver Message (<source>, Performance, …). Other GL driver message types, such as errors, are still reported.Test plan
checkBrowser.test.ts: a GPU stall note and an ordinary warning reach the console listener; only the ordinary warning is reported.does not report Chrome's GPU stall notes for check's own pixel reads as the film's warningsgoes red with thecheckBrowser.tschange reverted (1 failed, 74 passed); with it, 75 passed, 3 runs in a row.hyperframes check --jsonon a WebGL2 shader composition drawn fromhf-seek: before, 6console_warningfindings for GPU stalls; after, 0.oxfmt --check,oxlinton both files,tsc --noEmitforpackages/cli: clean.