Repository navigation
Conversation
When the layout audit reports text_occluded for an element, the contrast audit no longer measures a ratio against the opaque cover hiding it. The occluded finding already covers the text; the contrast failure was a duplicate measured against pixels no viewer sees. Fixes heygen-com#7711
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A label hidden under an opaque cover was reported twice: once as text_occluded by the layout audit, and again as a contrast failure measured against the cover itself. The second number describes nothing a viewer sees.
Now the contrast audit skips text the layout audit flagged as occluded at the same sample time. The occluded finding stays, and visible low-contrast text is still audited as before.
Fixes #7711