Repository navigation
Conversation
An absolutely positioned nowrap title is sized by its own text, not by its wrapper, so a shrink-to-fit wrapper (sized by unrelated in-flow content) is not an edge the title can overflow. Only the non-clipping branch changes: clipping containers and data-layout-boundary still check every child, and in-flow nowrap children still warn. Fixes heygen-com#7712
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hyperframes checkflagged absolutely positioned nowrap titles as overflowing their wrapper, even when the wrapper has no size of its own. The wrapper shrink-to-fit width comes from unrelated in-flow content (the kicker line), so it is not an edge the title can overflow.What changed: in
containerOverflowIssues, a nowrap child that isposition: absoluteorfixedis skipped when the container does not clip. Clipping containers anddata-layout-boundarystill check every child, and in-flow nowrap children still warn.Verified: added two tests in
layout-audit.browser.test.ts. The unsized-wrapper case no longer flags (failed before the fix, passes after), and an absolute nowrap child in a clipping container still flags. Full file suite passes, 222/222. oxlint and oxfmt clean.Fixes #7712