Repository navigation
Conversation
Lines that come on together and stay to the film's end are one closing card, so detectLineUnread groups final lines whose refined starts are within one sample and reports the card once, anchored on the line with the highest floor and listing the rest in elements. A line that arrives later than the rest keeps its own finding. Tests: craftAudit.test.ts now covers the seven-line card from the issue (one finding, floor 2.85 s) and a late signature (two findings).
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A film whose last frame is an end card made of several text elements got one line_unread finding per chunk, all saying the same thing: the card is held too briefly.
detectLineUnread now groups final lines whose refined start times are within one sample of each other into a single closing-card finding, anchored on the line with the highest floor and listing the rest in elements. A line that arrives later than the rest keeps its own finding, since its hold is different.
Verified: craftAudit.test.ts 29/29, including a seven-line card (one finding, floor 2.85 s) and a late signature (two findings). oxlint and oxfmt clean, comment citations and ratchet pass.
Fixes #7709