Repository navigation
Conversation
… file On a film built from many sub-composition scene files, text_below_floor reported the same style problem once for every file: 74 warnings for one 27 px label class, each anchored on its smallest text in its own file. The findings buried any real line_unread or dead_stretch findings under the repeats, and one CSS change fixes them all. Group SmallText entries by rounded rendered size before building findings, so one finding covers a style across files and lists every affected element with its sourceFile. Elements at different sizes stay separate findings. The craft layer carries no class list or font family, so the rounded size is the style key. Update the cli.mdx craft table and the lint-validate-inspect skill reference, which documented the old one-finding-per-file behavior. Fixes heygen-com#7710
Preview approval requiredThis pull request comes from a fork, so Mintlify won't build a preview until someone with write access approves commit |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a film built from many sub-composition scene files,
text_below_floorreported the same style problem once per file: 74 warnings for one 27 px label class. One CSS change fixes them all, and the repeats buried real findings underneath.The fix groups small-text entries by rounded rendered size, so one finding covers a style across files and lists every element with its file. Different sizes stay separate findings. The craft layer has no class or font-family data, so rounded size is the style key. Also updates the cli.mdx craft table and the lint-validate-inspect skill reference, which documented the old one-finding-per-file behavior.
Verified:
craftAudit.test.ts29/29, including 2 new tests (same size across files groups into one finding; different sizes stay separate) and the updated per-size test. The 3 new tests fail on the old code. oxlint and oxfmt clean. Typecheck shows only pre-existing missing-module errors from the unbuilt workspace, none in the changed files.Fixes #7710