Repository navigation
fix(check): time a line the next scene repeats in place as one line - #7704
Open
wonjangcloud9 wants to merge 1 commit into
Open
wonjangcloud9 wants to merge 1 commit into
wonjangcloud9 wants to merge 1 commit into
Conversation
line_unread tracked each element on its own, so a line that a scene cut carries over (the same words, in the same place, in the next sub-composition) was measured once per scene: an alert held 7 s across two scene files was reported as on screen 2.10 s, under its 3.53 s floor. A block that first appears where another block showed the same text one sample earlier now continues that line, so its hold is measured across the cut. The same words elsewhere on screen are still a separate line. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Preview approval requiredThis pull request comes from a fork, so Mintlify won't build a preview until someone with write access approves commit |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
line_unreadnow measures a line that a scene cut carries over (the same words, in the same place, in the next sub-composition) as one line, so its hold runs across the cut instead of stopping at it.Why
The craft pass tracked each DOM element on its own. A film that keeps an alert on screen across two scene files (scene A ends at 2.1 s, scene B starts at 2.1 s with the same
<div>text in the same place) showed the alert for 7 s, yetcheckreported the first copy only:This came from a real Short whose alert card continues from its cold open into the next scene.
Related work
line_unread,sub-composition,craft).How
trackBlocks(packages/cli/src/utils/craftAudit.ts): when a block is seen for the first time, and a block in the previous sample showed the same text in an overlapping box, the new block joins that block's track. A track now holds a set of block keys.refineWindow) andmeasuredAroundcheck any of the track's keys.docs/packages/cli.mdxcraft table andskills/hyperframes-cli/references/lint-validate-inspect.md(manifest regenerated).Test plan
measures a line the next scene repeats in place as one linefails onmain(expected [ { code: 'line_unread', … } ] to deeply equal []) and passes with the fix; a control test keeps the same words placed elsewhere as their own line.bunx vitest run src/utils/craftAudit.test.ts: 29 passed.hyperframes check --no-cache --json:main(0.9.43): 1line_unreadfinding, the alert at 2.10 s under its 3.53 s floor.a0.html→n1.html), the two carried-over lines (BALLISTIC MISSILE…,THE REAL ALERT · JAN 13, 2018…) no longer warn.fallow audit --base origin/main, comment ratchet, typecheck (pre-commit).🤖 Generated with Claude Code