Repository navigation
fix(check): line_unread names the captions track that exempts a caption - #7703
Open
wonjangcloud9 wants to merge 1 commit into
Open
wonjangcloud9 wants to merge 1 commit into
wonjangcloud9 wants to merge 1 commit into
Conversation
A caption timed to speech cannot stay on screen longer than its words take, so line_unread warned on every caption line of a voice-synced video (tens per Short) when the captions were plain clips. check already skips text under data-track-kind="captions", but the message never said so, and the only pointer was a sentence in the CLI docs. The message now offers the exemption next to the hold advice, the way text_below_floor offers data-layout-ignore, and the captions reference says check skips the captions track. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
line_unreadmessage now says how to exempt a caption timed to speech: putdata-track-kind="captions"on its clip or host. The captions reference now says thatcheckskips that track.Why
A caption timed to speech cannot stay on screen longer than its words take. A voice-synced Short whose captions were plain clips (
<div class="cap clip" data-start … data-track-index="2">) got aline_unreadwarning on almost every caption line, tens per video:checkalready skips text underdata-track-kind="captions"(isCaptionsTextinlayout-audit.browser.js). That exemption was only mentioned in a sentence under the craft table indocs/packages/cli.mdx. The message pointed only at holding the line longer, which the voice timing does not allow.caption_track_kind_missingdoes not help here either, because it only looks at sub-composition hosts.Related work
line_unread captions,craft).text_below_flooralready offers its opt-out (data-layout-ignore) in its message. This bringsline_unreadin line with it.How
packages/cli/src/utils/craftAudit.ts: bothline_unreadmessages (mid-film and the film's last line) end with…, or, if it is a caption timed to speech, put data-track-kind="captions" on its clip or host so this check skips it; see references/motion.md.skills/hyperframes/references/captions.md: the captions-track bullet sayscheckdoes not time its lines against the reading floor. Skills manifest regenerated.Test plan
names the captions track as the way to exempt a caption timed to speechfails onmainand passes with the fix.craftAudit.test.ts: 28 passed.hyperframes check --no-cache --json):main: 4line_unreadwarnings, and the messages do not mention captions.data-track-kind="captions".data-track-kind="captions"on each.capclip): 0 craft findings, onmaintoo.fallow audit, typecheck (pre-commit).🤖 Generated with Claude Code