Repository navigation
refactor(cli): keep the warm check idle timeout private to its module - #7702
Merged
Merged
Conversation
![heygengenesis[bot]](https://avatars.githubusercontent.com/in/2913576?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Verdict: APPROVE · 0 blocker · 0 important · 0 nits · head 724fb104. A refactor with no behaviour change, so the fails without the fix: rule does not apply. git grep WARM_IDLE_MS on this head finds only its two uses inside warmCheckProtocol.ts. Fallow audit and all CI checks pass.
Merged
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
WARM_IDLE_MSinpackages/cli/src/warmCheckProtocol.tsis no longer exported.Why
Since #7687 nothing outside this module imports it (
warmCheckClient.tsgoes throughwarmServerArgs), so the Fallow audit reportsfallow/unused-export. This was the open nit on #7687, which was already in the merge queue.Related work
Refs #7687
How
The
exportkeyword is removed. Nothing else changes.Test plan
grep -rn WARM_IDLE_MS packagesshows only the two uses inside this modulefallow audit --base origin/main: no issuesoxfmt --checkon the file: clean