Repository navigation
fix(cli): the render header names the quality preset and CRF it encodes with - #7697
Merged
miguel-heygen merged 1 commit intoNov 14, 2026
Merged
Conversation
…es with The settings line printed the encoder tier, so the default render said "30fps · standard · …" while it encoded the looks preset at CRF 16, and -q delivery said "high". A long-form render that came out at ~40 Mbps read as "standard quality" in its own log. The line now prints the --quality name as asked for and the CRF or bitrate in effect: "looks (CRF 16)" by default, "looks (CRF 20)" with --crf 20, "looks (10M)" with --video-bitrate 10M, "draft", "delivery". Co-Authored-By: Claude Opus 5.5 <[email protected]>
miguel-heygen
approved these changes
Nov 14, 2026
miguel-heygen
left a comment
Collaborator
There was a problem hiding this comment.
Verified at 1048d2d: the bug reproduces on main, and the new tests fail without the fix and pass with it. Required CI is green.
Merged
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The settings line
hyperframes renderprints before it starts now names the--qualitypreset that was asked for and the CRF or bitrate in effect, instead of the internal encoder tier:render(default)30fps · standard · auto workers (12 cores usable)30fps · looks (CRF 16) · auto workers (12 cores usable)render -q delivery30fps · high · …30fps · delivery · …render --crf 2330fps · standard · …30fps · looks (CRF 23) · …render --video-bitrate 10M30fps · standard · …30fps · looks (10M) · …render -q draft30fps · draft · …30fps · draft · …(unchanged)Why
Since #3927 the default is
looks, i.e. thestandardencoder tier with CRF 16 (QUALITY_ALIASESinpackages/cli/src/commands/render/plan.ts). The header printedplan.quality, which is the tier, so every default render announced itself asstandard. In practice: 8-minute long-form renders at the default came out at 2.4–2.6 GB (~40 Mbps) against 226 MB for-q draft, and the render's own log called that run "standard quality", which sent the user looking for why "standard" was so large rather than at the CRF 16 preset that--helpanddocs/packages/cli.mdxdescribe. The default itself is documented and deliberate; only the label was wrong.Related work
looks(CRF 16) the default anddeliverythe alias ofhigh.How
RenderPlancarriesqualityPreset, the--qualityname as given (lookswhen omitted), next to the existingqualitytier.present.tsprintsqualityLabel(plan): the preset name, plus(CRF n)when a CRF is in effect (the looks default or--crf) or(bitrate)with--video-bitrate. MOV keeps the bare preset name, as it takes no CRF.@hf-progresslines are unchanged. No doc page shows this line, so there is no doc text to update.Test plan
New
packages/cli/src/commands/render/present.test.ts: builds a plan withcreateRenderPlanand checks the printed settings line for the default,draft,standard,delivery,--crf 20and--video-bitrate 10M. On main'splan.ts/present.ts(fix stashed) 4 of the 6 cases fail, e.g.expected ' 30fps · standard · 2 workers' to contain '30fps · looks (CRF 16) · 2 workers'. With the fix all 6 pass;src/commands/render/79 tests pass.Real CLI on a 9 s 1080x1920 project:
Gates: oxlint / oxfmt clean,
fallow audit --base origin/mainno issues, comment ratchet at or under share, lefthook pre-commit (format, fallow, typecheck, cli-process-ownership) passed.