Repository navigation
docs: credit the OpenStreetMap and CARTO sources of the korea-map block asset - #7694
Open
wonjangcloud9 wants to merge 1 commit into
Open
wonjangcloud9 wants to merge 1 commit into
wonjangcloud9 wants to merge 1 commit into
Conversation
…ck asset north-korea-locked-down ships assets/korea-map.png, a static image of a CARTO basemap, and draws "© OpenStreetMap contributors © CARTO" on screen, but the repository recorded no source or licence for it. CREDITS.md's third-party section, where the other registry blocks' outside assets are listed, now names the data (OpenStreetMap, ODbL-1.0), the map style (CARTO, CC BY 4.0) and the CARTO basemap-terms clause on static images that requires both credits to stay legible. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
One entry in
CREDITS.md→ "Third-party licenses" fornorth-korea-locked-down/assets/korea-map.png: a static image of a CARTO basemap; map data © OpenStreetMap contributors (ODbL-1.0); map style © CARTO (CC BY 4.0); CARTO's basemap terms §9.d cover static images and require both credits to be legible in the image; the block draws that credit, keep it wherever the map is shown.Why
hyperframes add north-korea-locked-downinstallsassets/korea-map.png(492 KB, a CARTO light basemap screenshot of Northeast Asia) into the user's project. The block's HTML draws© OpenStreetMap contributors © CARTObottom-right (19 px, faint but readable in a 6 s snapshot), but nothing in the repository records where the image came from or under what terms:registry-item.jsonhas nolicense, andCREDITS.md— where the third-party assets of the other blocks (three.js, GSAP, fonts, the Poly Haven HDR, "origin to be confirmed" textures) are listed — has no entry. A user reusing the PNG elsewhere has no way to know the credit is required.Convention check: the per-item
licensefield is an SPDX id for the item itself (36 shader blocks, a few components); blocks that ship outside assets (canopy-part-title,glass-shard-title,cuboid-carousel, …) leave it unset and are credited inCREDITS.md. So this followsCREDITS.md, not the manifest field.Sources, quoted:
CartoDB/basemap-stylesLICENSE.md: "# Design license: CC-BY 4.0 — The visual design features of the style … are licensed under the Creative Commons Attribution 4.0 license."Related work
No existing issue or PR. #4081 touched this block's animation only.
How
Text only, in the style of the surrounding entries. No behaviour change.
Open question for maintainers (not decided by this PR): the same LICENSE.md says CARTO's hosted tiles are "restricted to CARTO enterprise customers and Non-Profit GRANTS only", and §9.d's allowance is for "illustrative, editorial or documentary purposes". Whether shipping the screenshot in an Apache-2.0 registry for any use (including commercial videos) fits that is a call for you or the block's author; if not, the alternative is re-rendering the map from Natural Earth (public domain) data. This PR only records the facts so the credit isn't lost meanwhile.
Test plan
hyperframes add north-korea-locked-down, mounted,snapshot --at 1,6—© OpenStreetMap contributors © CARTOvisible bottom-right.🤖 Generated with Claude Code