Skip to content

docs: credit the OpenStreetMap and CARTO sources of the korea-map block asset - #7694

Open
wonjangcloud9 wants to merge 1 commit into
heygen-com:mainfrom
wonjangcloud9:docs/credit-korea-map
Open

wonjangcloud9 wants to merge 1 commit into
heygen-com:mainfrom
wonjangcloud9:docs/credit-korea-map

Conversation

@wonjangcloud9

Copy link
Copy Markdown
Contributor

Context: I've been using HyperFrames every day for the past two weeks to make Korean Shorts and long-form videos, and it's been great to work with. This PR is one of a batch of fixes for things I ran into along the way, so you'll see several PRs from me at once — sorry for the pile-up, and thanks for your patience. Each one is reproduced on current main, independent of the others, and can be reviewed, merged or closed on its own.

What

One entry in CREDITS.md → "Third-party licenses" for north-korea-locked-down/assets/korea-map.png: a static image of a CARTO basemap; map data © OpenStreetMap contributors (ODbL-1.0); map style © CARTO (CC BY 4.0); CARTO's basemap terms §9.d cover static images and require both credits to be legible in the image; the block draws that credit, keep it wherever the map is shown.

Why

hyperframes add north-korea-locked-down installs assets/korea-map.png (492 KB, a CARTO light basemap screenshot of Northeast Asia) into the user's project. The block's HTML draws © OpenStreetMap contributors © CARTO bottom-right (19 px, faint but readable in a 6 s snapshot), but nothing in the repository records where the image came from or under what terms: registry-item.json has no license, and CREDITS.md — where the third-party assets of the other blocks (three.js, GSAP, fonts, the Poly Haven HDR, "origin to be confirmed" textures) are listed — has no entry. A user reusing the PNG elsewhere has no way to know the credit is required.

Convention check: the per-item license field is an SPDX id for the item itself (36 shader blocks, a few components); blocks that ship outside assets (canopy-part-title, glass-shard-title, cuboid-carousel, …) leave it unset and are credited in CREDITS.md. So this follows CREDITS.md, not the manifest field.

Sources, quoted:

  • CartoDB/basemap-styles LICENSE.md: "# Design license: CC-BY 4.0 — The visual design features of the style … are licensed under the Creative Commons Attribution 4.0 license."
  • https://carto.com/legal/basemap-terms/ §9.d: "Customer may use screenshots or other static images of CARTO basemaps for illustrative, editorial or documentary purposes, provided that the attribution required by Section 13 is legible in the image." §13: "Customer must provide attribution to both OpenStreetMap and CARTO."

Related work

No existing issue or PR. #4081 touched this block's animation only.

How

Text only, in the style of the surrounding entries. No behaviour change.

Open question for maintainers (not decided by this PR): the same LICENSE.md says CARTO's hosted tiles are "restricted to CARTO enterprise customers and Non-Profit GRANTS only", and §9.d's allowance is for "illustrative, editorial or documentary purposes". Whether shipping the screenshot in an Apache-2.0 registry for any use (including commercial videos) fits that is a call for you or the block's author; if not, the alternative is re-rendering the map from Natural Earth (public domain) data. This PR only records the facts so the credit isn't lost meanwhile.

Test plan

  • Verified the block still draws the credit: hyperframes add north-korea-locked-down, mounted, snapshot --at 1,6 — © OpenStreetMap contributors © CARTO visible bottom-right.
  • Quotes checked against the live CARTO terms page and the raw LICENSE.md.
  • Unit tests — n/a (text-only change to CREDITS.md)
  • Documentation updated (this is the documentation)
  • oxfmt clean; pre-commit hooks pass.

🤖 Generated with Claude Code

…ck asset

north-korea-locked-down ships assets/korea-map.png, a static image of a
CARTO basemap, and draws "© OpenStreetMap contributors © CARTO" on screen,
but the repository recorded no source or licence for it. CREDITS.md's
third-party section, where the other registry blocks' outside assets are
listed, now names the data (OpenStreetMap, ODbL-1.0), the map style
(CARTO, CC BY 4.0) and the CARTO basemap-terms clause on static images
that requires both credits to stay legible.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant