Skip to content

fix(cli): stop the CLI build looking for the removed gsap skill - #7689

Merged
miguel-heygen merged 1 commit into
heygen-com:mainfrom
wonjangcloud9:fix/build-copy-stale-gsap-skill
Nov 14, 2026
Merged

miguel-heygen merged 1 commit into
heygen-com:mainfrom
wonjangcloud9:fix/build-copy-stale-gsap-skill

Conversation

@wonjangcloud9

Copy link
Copy Markdown
Contributor

Context: I've been using HyperFrames every day for the past two weeks to make Korean Shorts and long-form videos, and it's been great to work with. This PR is one of a batch of fixes for things I ran into along the way, so you'll see several PRs from me at once — sorry for the pile-up, and thanks for your patience. Each one is reproduced on current main, independent of the others, and can be reviewed, merged or closed on its own.

What

Remove the stale "gsap" entry from the list of skills packages/cli/scripts/build-copy.mjs bundles into the published CLI, and add a unit test that every name on that list has a skills/<name>/SKILL.md.

Why

Every CLI build on main prints:

$ node scripts/build-copy.mjs
[build-copy] skill not found, skipping: skills/gsap
[build-copy] done

skills/gsap was removed in #1349 (2026-06-14, "video-creation workflow suite"), which folded its content into the animation skill — the same PR that added the existsSync guard and the warning. The list was never updated, so the warning has fired on every build since and trains people to ignore build-copy warnings that might one day matter.

Related work

No existing issue or PR (searched "build-copy gsap", "skills/gsap").

How

  • build-copy.mjs: ["hyperframes", "hyperframes-cli", "gsap", "media-use"] → ["hyperframes", "hyperframes-cli", "media-use"]. Nothing reads dist/skills/gsap (the directory was never produced after feat(skills): video-creation workflow suite — routable workflows #1349).
  • packages/cli/src/buildCopy.test.ts: reads the script's source (as init.test.ts already does for the templates list), extracts the bundled-skill names and asserts each has a SKILL.md. The existsSync guard stays, so a branch with a different skills tree still builds; CI is what catches a stale name.

Test plan

  • Unit test added: on main it fails with missing = ["gsap"]; with the fix it passes.
  • Manual: node scripts/build-copy.mjs — main prints the skill not found … skills/gsap line; this branch prints only [build-copy] done, and dist/skills still holds hyperframes, hyperframes-cli, media-use (same as before).
  • Documentation updated — n/a (build script only)
  • Comments follow CONTRIBUTING.md "Comments"
  • Gates: oxlint, oxfmt, typecheck, fallow, comment ratchet — pass.

🤖 Generated with Claude Code

skills/gsap was folded into the animation skill in heygen-com#1349, but build-copy
still listed it, so every CLI build printed "[build-copy] skill not found,
skipping: skills/gsap". Drop the entry, and add a test that every bundled
skill name has a SKILL.md so the next rename fails CI instead of warning.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

@miguel-heygen miguel-heygen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified at d8ae190: the bug reproduces on main, and the new tests fail without the fix and pass with it. Required CI is green.

@miguel-heygen
miguel-heygen added this pull request to the merge queue Nov 14, 2026
Merged via the queue into heygen-com:main with commit c66a430 Nov 14, 2026
84 checks passed
@heygengenesis heygengenesis Bot mentioned this pull request Nov 14, 2026
1 of 2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants