Repository navigation
fix(lint): name the clip without data-duration in the audio overlap hint - #7386
Open
lukaskourilcz wants to merge 1 commit into
Open
lukaskourilcz wants to merge 1 commit into
lukaskourilcz wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 <[email protected]>
3 of 4 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When duplicate_audio_track fires because clip has no data-duration, the hint now says which clip it is and to set data-duration to the file length.
Why
I made a video with 8 voice lines one after another on one track, without data-duration (docs say audio without it plays full length). Lint doesnt read the files so every line counts until the end of composition, and I got 28 warnings like
v3.wav at 10.4-46s. Hint said "Use non-overlapping time windows or different track indices" but windows didnt overlap at all. Adding data-duration fixed it, took me a while to figure out.Related work
Same rule as #5837 and #6005. Detection stays the same. Making lint read real media length is bigger change, would open issue for that first.
How
AudioSpan remembers if duration was unknown (
runsToWindowEnd) and fixHint lists those files, otherwise old hint.Test plan
bun run --filter @hyperframes/lint test(1282 passed), typecheck🤖 Generated with Claude Code