Repository navigation
feat(media-use): the voice credits line names the real source, your recording or any vendor - #7380
Merged
Merged
Conversation
![heygengenesis[bot]](https://avatars.githubusercontent.com/in/2913576?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Verdict: APPROVE · 0 blocker · 0 important · 0 nits · head 2eb776b1
Checked
Checked the fails without the fix: claim by stubbing voiceCredit to always return HeyGen's wording: both voice-credit.test.mjs cases and the recording.test.mjs voice_credit assertion fail, and all pass on this head (8/8, 0 skipped). The credit is rebuilt from the merged prev.voices/prev.tts_provider, so a --only bgm/--only sfx rerun keeps the right line and doesn't null it. The manifest diff is only the hash and file count. Base is feat/voice-own-recording (#7377, approved), so this lands on that branch, not main. CI not read: this identity can't read check-runs (mergeStateStatus CLEAN).
miguel-heygen
dismissed
heygengenesis[bot]’s stale review
November 7, 2026 20:16
The base branch was changed.
…ecording or any vendor
miguel-heygen
force-pushed
the
feat/voice-credit
branch
from
November 7, 2026 20:21
2eb776b to
5474a68
Compare
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
audio_meta.jsongetsvoice_credit, the credits line for the voices of a run, naming where each really came from: "Voice: your own recording", "Voice: AI-generated by ElevenLabs" (or HeyGen, Google Gemini, Kokoro), or a mix joined with "; ". The style-sampling remix rule now points at it instead of a HeyGen-only wording.Why
Discord, "Use your own voice recording": the credits line could not name another vendor. Root cause: no code wrote a credits line at all. The only rule was prose in
skills/style-sampling/references/remix.md:26("name it in the credits as AI-generated", written for a HeyGen stock voice), so whatever voice was used, the credit was HeyGen's wording. The engine knows the real source (tts_provider, andsource: "recording"per voice from #7377), so it now writes the line and the skill uses it as is.Related work
Builds on #7377 (merged); it uses that PR's
voice.source. Refs the same Discord report as #7366 (merged).How
New
skills/media-use/audio/scripts/lib/voice-credit.mjs(one map of provider to vendor name, one function).audio.mjswritesvoice_creditinto the meta it already writes. Searched for an existing credits writer: none (grep -rn "credit" skills/media-use/audiofinds only SFX licence credits insfx.mjs/openverse.mjs, a different thing).Test plan
skills/media-use/audio/scripts/lib/voice-credit.test.mjs"a generated voice is credited to the vendor that made it, not always HeyGen" and "a recording is credited as the person's own, and a mix names both" (both fail when every credit says HeyGen), plus thevoice_creditassertion inrecording.test.mjs.oxfmtandoxlintclean; skills manifest regenerated; skill mirror OK.references/audio.md,remix.md)Size
A small follow-up that belongs with #7377's recording work but is a separate review: the credits line is its own behavior change, and folding it in would reopen an approved PR.
Size: 53 lines on its own; it was stacked on #7377, which has merged, and this lane has no other open PR to carry it.