Repository navigation
docs(producer): say the setup budget bounds each step, not setup as a whole - #7333
Closed
miguel-heygen wants to merge 1 commit into
Closed
miguel-heygen wants to merge 1 commit into
miguel-heygen wants to merge 1 commit into
Conversation
Contributor
miguel-heygen
force-pushed
the
docs/setup-budget-comment
branch
from
November 6, 2026 20:14
cea7dcd to
80387ab
Compare
![heygengenesis[bot]](https://avatars.githubusercontent.com/in/2913576?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Approved at 80387ab6. I checked the new comment against createStallClock. setup.idle(0) adds any gap over 0 + SUSPEND_GAP_MS (15 s) to since, so a setup step longer than 15 s is dropped from the shared clock, and the next step gets the full initStallMs again. "Bounds each step, not setup as a whole" is accurate. Steps under 15 s still count against the shared budget, which matches "drops a step longer than its suspend gap". The change is a comment only and behaviour is the same. Not a fix PR, so no fails-without-the-fix line is needed.
5 of 6 tasks
Collaborator
Author
|
Folded into #7337, which carries this comment change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Corrects the doc comment on
createSessionInitBudget. It said each setup step races against what is left of one clock; each step is actually bounded by the budget on its own. No code change.Why
createStallClockleaves out any gap longer than its 15 s suspend margin.idle(0)between setup steps therefore drops the time spent inside a long step, so a slow open does not shorten the init after it, and setup as a whole can take up to one budget per step. A review of #7329 pointed this out after it had entered the merge queue.Related work
Refs #7329.
How
Comment only, in
captureStreamingStage.ts. Behaviour stays as it was: moving to one shared deadline would also tighten the streaming route, so that is a separate decision.Test plan