Repository navigation
audio: --layer read mode for declared single-layer files (proposal) - #7321
Closed
jerrai-bot-heygen wants to merge 2 commits into
Closed
jerrai-bot-heygen wants to merge 2 commits into
jerrai-bot-heygen wants to merge 2 commits into
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
Contributor
Fallow audit reportQuality gate failed Found 1 finding. Health (1)
Generated by fallow.
|
SanHsien
added a commit
to SanHsien/hyperframes
that referenced
this pull request
Nov 6, 2026
…, record duplicate rule Review PR heygen-com#7304-heygen-com#7335: 10 merged already adopted or deferred; 10 open or draft PRs pinned (heygen-com#7304, heygen-com#7308, heygen-com#7311, heygen-com#7315, heygen-com#7321, heygen-com#7330-heygen-com#7334); open duplicates of pinned heygen-com#7281/heygen-com#7285/heygen-com#7286/heygen-com#7296 are tracked by those pins. strict exit 0; monitored 110 -> 120. Co-Authored-By: Claude Sonnet 5.5 <[email protected]> Co-Authored-By: Claude Opus 5.5 <[email protected]>
Contributor
Author
|
Superseded by #7345 (merged 2026-11-07 03:43Z), which ships the same |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposal from the Cut Room team, awaiting Rory's or Miguel's OK. It is a draft; we are not asking to merge it before they agree with the direction.
Why
Cut Room generates music takes. Each take is already a single layer, but
hyperframes audio --readonly builds its music reading from separated stems, so every new take pays for a stem separation (--quality best, billed through HeyGen). In one studied session that separation was 44% of media spend. Without it,musiccomes backnull.What
hyperframes audio <file> --read --layer music|sfx|voicedeclares the whole file to be one layer.music: the file is read as its own stem throughreadMusic(segments, breaks, bpm, ambience). No separation runs. Voice and effects are not read (null), with the warningdeclared single-layer music: not separated, and the other layers are not read.sfx: the file is the effects source forfindEffects; no music, no voice.voice: separation is skipped; voice lines come from the transcript if given, else from activity, as today's no-stems path does.declared single-layer <layer>, and the JSON carrieslayer. The cache is keyed on the declared layer, so a file read with and without--layernever reuses the wrong entry.--layer, behaviour is unchanged (the field is absent).--layerwithout--read, or with an unknown value, is a usage error.Detection:
hyperframes audio --helplists--layer; an older CLI rejects it as an unknown flag. The--read --jsonoutput includes"layer"on a layer read.Tests
packages/cli/src/audio/read/read.test.ts: music take with--layer musicyields music segments with zero stem calls, and the plain read of the same file is unchanged;voiceandsfxread without separation. 15/15 pass locally; oxlint and oxfmt are clean.Open question for the owners
Is whole-file
sfxuseful, or should we ship music only?— Jerrai