Repository navigation
feat(cli): print the render's reference_background as an @hf-result line - #7203
Merged
jerrai-bot-heygen merged 1 commit intoNov 5, 2026
Merged
jerrai-bot-heygen merged 1 commit into
jerrai-bot-heygen merged 1 commit into
Conversation
…ine and in batch manifest rows A piped, non-quiet local render now writes one versioned @hf-result JSON line after success. Batch manifest rows carry the same reference_background value. Co-Authored-By: Jerrai <[email protected]>
Contributor
Contributor
There was a problem hiding this comment.
Verdict: APPROVE · 0 blocker · 0 important · 0 nits · head b07d99fa
The writer only re-emits the reference_background that renderLocal/renderRange already return, and passes it through referenceBackgroundResult again first. It uses the same TTY, HYPERFRAMES_STDOUT_IS_TTY and quiet gates as @hf-diagnostic. A failed render throws before the writer runs.
Scope
Read all 7 files. Checked:
effectiveQuiet = quiet || args.json(plan.ts:644), so a single--jsonrender prints no extra stdout line.- Batch rows get the field through
executeBatchRender, notexecuteHeldRender, so a batch run prints no per-row@hf-resultlines from the host. - Docker rows/launcher return no field, so rows stay
nulland the launcher prints nothing. A non-quiet container inherits stdout and its own CLI may emit the line, which matches what the README says. - The manifest change only adds a key, so keeping version 1 is fine.
All 8 Actions workflows on this head are green.
jerrai-bot-heygen
deleted the
jerrai/hf-render_result_reference_background-11052026
branch
November 5, 2026 02:36
SanHsien
added a commit
to SanHsien/hyperframes
that referenced
this pull request
Nov 5, 2026
…eview Adopts heygen-com#7199 (delivery-PCM duration normalization), heygen-com#7194 (browser install retries while Windows holds a file), the Studio marquee and timeline range-selection series, waapi initial-state, lint media and CLI check/contrast fixes, and skills docs. Not adopted with ledger reasons: heygen-com#7203, heygen-com#7207, heygen-com#7202, heygen-com#7197; limitDeliveryPeaks and the neverStyledStarts cache are left out because the fork lacks their prerequisites. Watermark advances to aa34cff / PR heygen-com#7190. Co-authored-by: WaterrrForever <[email protected]> Co-authored-by: Miguel Ángel <[email protected]> Co-authored-by: kevin <[email protected]> Co-authored-by: Jason <[email protected]> Co-authored-by: cooleryu <[email protected]> Co-authored-by: Vincent Yip <[email protected]> Co-authored-by: Vance Ingalls <[email protected]> Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A piped, non-quiet local render now prints one
@hf-resultJSON line after it succeeds, carrying thereference_backgroundthe render already measured. Batch manifest rows carry the samereference_backgroundvalue.reference_backgroundis exactly one of{"kind":"solid","rgb":[r,g,b]},{"kind":"none"},{"kind":"unsupported_non_solid"},{"kind":"unknown"}: the objectrenderLocal/renderRangealready return, re-projected throughreferenceBackgroundResultat the writer. No new computation.Why
renderLocalreturnsreference_background, but nothing printed it: the single-render path discarded the returned object and batch rows copied onlydurationMsandrenderTimeMs. A caller that runshyperframes renderas a subprocess (piped stdout, no--json) could not read the measured background. This is the same transport as@hf-diagnosticand@hf-progress, so it needs no new flag.Related work
Builds on the measurement merged in #7007. Refs: Cut Room harness row D56-24 (blank scan should compare against the composition's own background).
How
packages/cli/src/ui/renderResult.ts:renderMachineResult, written likerenderMachineDiagnostic: silent on a terminal or whenHYPERFRAMES_STDOUT_IS_TTY=1, silent in quiet mode (including batch JSON), one line, version 1.executeHeldRenderprints it once from the value the single-render executor returns. A failed render throws before the call, so a failure never prints it. A--dockerlauncher gets no field back and prints nothing.BatchManifestRow.reference_backgroundisnulluntil the row completes and staysnullfor a failed row. Manifestversionstays 1 (additive key).packages/cli/README.mddocuments the line next to@hf-diagnostic.Changeset / release note: none needed for the PR; release notes are drafted by
release:prepare.Test plan
Tests that fail on the old code and pass on this head (checked by restoring only
execute.tsandbatchRender.tstoorigin/main):execute.test.ts> "the machine result line after a single render" > prints the render's reference background once (solid, none, unsupported_non_solid, unknown): expected one line, got none.batchRender.test.ts> "copies each row's reference background into the manifest and leaves a failed row null".Also covered, passing on both: no line on a failed render, no line in quiet mode, no line when a Docker render reports no background (
execute.test.ts); line shape, single line, malformed value re-projected tounknown, silent on terminal /HYPERFRAMES_STDOUT_IS_TTY=1/ quiet (renderResult.test.ts, new module).Ran locally:
renderResult.test.ts,execute.test.ts,batchRender.test.ts(38 tests pass),oxfmt,oxlint,tsc --noEmiton the cli package (only pre-existing@hyperframes/inspector/liveerrors from an unbuilt package),check-comment-citations.mjs.Could not verify
hyperframes renderprocess; the single-render test drivesexecuteRenderPlanwith a stub executor that returns each of the four kinds.comment-ratchet.mjsneeds full history; CI runs it.Authored by Jerrai.