Repository navigation
fix(figma): don't take a motion key from the tail of a longer name - #6810
MoonPointer-Byte wants to merge 1 commit into
Conversation
Looking up y matched the y in opacity, so a fade and a rise copied the opacity track onto y. Fixes heygen-com#6756
jrusso1020
left a comment
jrusso1020
left a comment
There was a problem hiding this comment.
Reviewed at 82696b7c37e5c2bc87b6c918ea94b3dcd70c7752.
Thanks, this fixes the same suffix-key collision as #6800. I reviewed both and prefer #6800's shared key matcher because it also handles whitespace around the property-object colon. I have approved that implementation. I'd merge one and then close the other as duplicate, rather than land two overlapping fixes. Your focused suite passed 8 tests; no live Figma import was run.
Need: yes · Size: ok · Reuse: existing shared implementation · Simpler: avoid parallel paths · Structure: fine
Risk: low - overlapping parser fixes.
Verdict: COMMENT
Reasoning: The next action above remains before a new approval.
Reasoning: Thanks, this fixes the same suffix-key collision as #6800. I reviewed both and prefer #6800's shared key matcher because it also handles whitespace around the property-object colon. I have approved that implementation. I'd merge one and then close the other as duplicate, rather than land two overlapping fixes. Your focused suite passed 8 tests; no live Figma import was run.
|
This PR has had no activity for 14 days, so it is marked stale and will close in 7 days. Push a commit or leave a comment to keep it open. A maintainer can add |
Summary
ywas matching the last letter ofopacity, so a layer that fades and moves copied the opacity values and timing onto theytrack.{...}lookups.opacityandyare animated together.Fixes #6756
Test plan
pnpm exec vitest run packages/core/src/figma/motionContextToDocs.test.ts