Repository navigation
fix(studio): leave NumberField IME confirmation to the input method - #6512
shuaiyafei wants to merge 1 commit into
Conversation
Preview approval requiredThis pull request comes from a fork, so Mintlify won't build a preview until someone with write access approves commit |
Port of upstream PR heygen-com#6512 (head 3530934, open): the Enter that confirms an IME composition (isComposing, or keyCode 229 on older WebKit) no longer commits the inspector value; a later plain Enter still commits once. Adopted ahead of upstream because zh-TW input is this fork's main case. Co-Authored-By: Claude Opus 5.5 <[email protected]>
…e watermarks Commit axis to bf7ebe9 (merge 2fa8452), PR axis to heygen-com#6629 and issue axis to heygen-com#6610, each item with its verdict, head SHA and trigger in docs/DECISIONS.md 2026-10-28. Upstream PR heygen-com#6512 is adopted (554dbb7). Co-Authored-By: Claude Opus 5.5 <[email protected]>
jrusso1020
left a comment
jrusso1020
left a comment
There was a problem hiding this comment.
Reviewed at 35309340fd7cd46180b293b02eea47dabed36d98.
The Enter guard keeps both native composition and older WebKit keyCode 229 in the input method. The normal commit and blur dedup paths are unchanged.
Attempted vitest numberFieldComposition.test.tsx --environment jsdom: collection blocked by missing @base-ui/react/number-field. No real IME/browser walk. One unsigned commit remains. Small source guard and authored native-event cases inspected.
Need: yes · Size: ok · Reuse: existing implementation seam · Simpler: already minimal · Structure: fine
Risk: low - IME commit handling.
Verdict: APPROVE
Reasoning: The Enter guard keeps both native composition and older WebKit keyCode 229 in the input method. The normal commit and blur dedup paths are unchanged.
Reasoning: The Enter guard keeps both native composition and older WebKit keyCode 229 in the input method. The normal commit and blur dedup paths are unchanged.
|
Thanks, @shuaiyafei. This is approved, and the only thing holding it back is commit signing: To re-sign and push: git rebase origin/main --exec "git commit --amend --no-edit -S"
git push --force-with-leaseGitHub's setup guide: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits If the content is unchanged, we'll queue it at your new head. — Rames |
What
Leave NumberField's IME confirmation Enter to the input method instead of committing the inspector value immediately.
This follows the NumberField feedback on #6011. It covers active composition and the legacy WebKit confirmation event (
keyCode === 229, even whenisComposingis false). A subsequent ordinary Enter still commits and tracks the change once.How
Guard the existing Enter handler before it prevents the key or calls
commitFromText(). Add two regressions and a short numeric-entry note to the canvas guide.Related work: #6011 covers the text
Input; #5947 covers NumberField range clamping.Before
After
The captures render the actual React component in Chromium with explicit synthetic keyboard events. Operating-system IME behavior and a Safari browser were not exercised.
Verification
mint validateandmint broken-linkspass.AI assistance: Codex.