Repository navigation
feat(cli): offer the HyperFrames app download on Windows - #6442
Merged
Merged
Conversation
The CLI and Studio now point Windows to the app download. Studio names the Windows download in its install steps.
![heygengenesis[bot]](https://avatars.githubusercontent.com/in/2913576?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Verdict: REQUEST CHANGES · 1 blocker · 1 important · 1 nit · head b76b5293
The code is fine: one DOWNLOADS entry feeds every surface, and the 37 CLI and 21 Studio tests pass locally.
- blocker: the required
Studio and player capturescheck fails.## No visible changeis only allowed when the diff has no.tsxfile, and this one hasDesktopGuideCard.tsx. On Windows the change is visible anyway: there is a new button and a new "Download for Windows" step. Add## Before/## Aftersections with captures (a Windows-platform Studio mock is enough). This needs a body edit, not code. - important (merge order):
https://www.hyperframes.dev/studio/download?os=windowscurrently returns 307 →/studio#studio-start(same as?os=bogus;?os=linuxserves the AppImage). Until the page change ships, a Windows "Download for Windows" press lands on the landing page with no download. Merging after that change avoids it. - nit: "Machines where the app is installed behave as before" is not true for the CLI.
HANDOFF_READYis darwin-only, sodesktopHintnow prints the download line after every render and preview on a Windows machine that already has the app (desktopApp.ts:245-248; before, it printed nothing). Linux already works this way, so this may be intended, but the body should say so.
— Claude
Contributor
Edit accuracy: accurate 271 (base branch 271), smooth 158 of thoseThe gate passes. Quarantined, measured but not gated (0) Unstable (1)
|
SanHsien
added a commit
to SanHsien/hyperframes
that referenced
this pull request
Oct 26, 2026
Merge 20 more upstream commits (acd0bc3..ad4d3fa, v0.8.205: heygen-com#6403, heygen-com#6363, heygen-com#6209, heygen-com#6395, heygen-com#6424, heygen-com#6426, heygen-com#6442, heygen-com#6430, heygen-com#6402, heygen-com#6435, heygen-com#6439, heygen-com#6449, heygen-com#5436, heygen-com#6455 and docs). No conflicts. Record the 11 open PRs heygen-com#6440-heygen-com#6458 and issue heygen-com#6443 in docs/DECISIONS.md (none adopted), re-check the earlier open PRs, and advance the commit watermark to ad4d3fa, the PR watermark to heygen-com#6458 and the issue watermark to heygen-com#6443. Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
On Windows, the CLI and Studio now offer the HyperFrames app download (
/studio/download?os=windows) the same way they do on macOS and Linux:hyperframes renderandhyperframes previewprint the download line.hyperframes openpoints a Windows machine without the app to the download.Machines where the app is installed behave as before.
No visible change
On macOS and Linux nothing changes. The Windows wording appears only on a Windows machine, where there was no button and no download line before.
Before
On Windows, Studio's header had no desktop-app button (the preview server answered that no build existed). Capture below.
After
The button "Install the desktop app" shows, and its guide reads "Download HyperFrames for Windows". The Windows answer is a mocked
/api/open-in-desktopresponse, the one the server tests assert for a Windows machine.Why
The signed Windows app is launching, and these surfaces hid Windows because no build existed.
Related work
The download page itself accepting
os=windowsships separately; this change points to it.How
DOWNLOADSgainswin32. Every surface (download line,open, the Studio route) reads that one table, so nothing else needed a Windows special case.platformNamein the guide card names Windows instead of "your computer".Test plan