Repository navigation
chore(studio-server): raise the package size budget to the measured size - #6370
Merged
Merged
Conversation
…ize plus headroom
miguel-heygen
force-pushed
the
checklong/studio-server-budget
branch
from
October 26, 2026 01:38
50b74e1 to
a31d40b
Compare
![heygengenesis[bot]](https://avatars.githubusercontent.com/in/2913576?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Verdict: APPROVE · 0 blocker · 0 important · 0 nits · head a31d40b0
Both new budgets are exactly ceil(1.05 × measured) (147082 → 154437, 574751 → 603489), the 5% convention in scripts/verify-packed-manifests.mjs. Main's size (~146 KB packed) stays above the 85% ratchet floor, so the size check doesn't flip on main. Only the budget file changes, and all workflows are green at this head.
— Genesis
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Raises the studio-server package size budget to 154437 bytes packed and 603489 unpacked (the usual 5% above the measured size).
Why
Merge-queue batches that hold several studio-server changes fail the Build size check: the packed tarball is 147082 bytes against a budget of 145266 (1% tolerance, so the limit is 146718), and unpacked is 574751 against 568500. Each of those PRs passes alone; together they cross the line, so the queue keeps ejecting them.
The growth is source, not junk. Main alone packs at about 146190 bytes. A listing of the tarball holds only
distJavaScript and type declarations (the largest areindex.jsat 268 KB and one shared chunk at 105 KB), with no source maps, tests, fixtures or media. It comes from the preview copy work that landed since the budget was last set: alpha cut-out copies, resumable copies, and the refused-frame reply.Tests
scripts/verify-packed-manifests.mjsreads the budget; the Build job runs it.