Repository navigation
docs: connect product-film close-ups to the full workspace - #6209
Conversation
Preview approval requiredThis pull request comes from a fork, so Mintlify won't build a preview until someone with write access approves commit |
miguel-heygen
left a comment
miguel-heygen
left a comment
There was a problem hiding this comment.
Thanks for the clear write-up. The workspace, close-up, return structure fits the existing launch guidance well: it keeps the "real UI, real labels" rule and adds no new timing or size numbers. I ran the skill lint, core-skill budget, mirror and formatter checks on this branch, and all pass.
A few small things:
launch.md: "while a tour shows the site as it is" refers to a "tour", but the skill has no tour type or definition, so an agent can't tell what it's being contrasted with. I'd drop the comparison or call it a site walkthrough.product-launch-video.mdx: "colour revision" sits on a page that otherwise says "Color", and the docs mostly use "color". Worth matching.- Optional: steps 2 and 3 partly repeat the "Rebuild only the piece the beat uses" and "Pull back to reveal..." bullets right below. Folding them together would keep the reference shorter, but I'm fine either way.
CI hasn't run on this branch yet (fork workflows need a maintainer to approve them), so I'm leaving a comment rather than an approval for now. The content looks good to me once the wording nits are settled and the checks are green.
Verdict: COMMENT
Reasoning: Content is sound and local lint/format checks pass, but no required CI check has run on the fork yet, so it can't be approved; remaining notes are minor wording.
c7010d1 to
210fa2f
Compare
miguel-heygen
left a comment
miguel-heygen
left a comment
There was a problem hiding this comment.
Thanks for the update. All three notes from the last round are addressed: the "tour" comparison is gone, the docs page now says "color" throughout, and the size and pull-back rules are folded into steps 2 and 3 without losing any of their wording. I also checked that the regenerated skills manifest matches the edited reference at this head, and it does.
The content looks ready to me. The CI workflows on this branch are still waiting for a maintainer to approve them, so I'm leaving a comment for now; once they run green I'm happy to approve.
Verdict: COMMENT
Reasoning: Every earlier note is fixed and the manifest is in sync, but no CI workflow has run on the fork head yet, so it cannot be approved.
210fa2f to
b2ff9e6
Compare
miguel-heygen
left a comment
miguel-heygen
left a comment
There was a problem hiding this comment.
CI has now run on the fork head and everything is green. The content is the one I checked at the last round: the "tour" comparison is gone, the docs say "color" throughout, the size and pull-back rules sit in steps 2 and 3, and the skills manifest is in sync. Thanks for the quick fixes.
Verdict: APPROVE
Reasoning: All earlier notes are fixed, the manifest is in sync, and all checks pass at this head.
Merge 20 more upstream commits (acd0bc3..ad4d3fa, v0.8.205: heygen-com#6403, heygen-com#6363, heygen-com#6209, heygen-com#6395, heygen-com#6424, heygen-com#6426, heygen-com#6442, heygen-com#6430, heygen-com#6402, heygen-com#6435, heygen-com#6439, heygen-com#6449, heygen-com#5436, heygen-com#6455 and docs). No conflicts. Record the 11 open PRs heygen-com#6440-heygen-com#6458 and issue heygen-com#6443 in docs/DECISIONS.md (none adopted), re-check the earlier open PRs, and advance the commit watermark to ad4d3fa, the PR watermark to heygen-com#6458 and the issue watermark to heygen-com#6443. Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
What
Clarify how a product-launch film connects independently animated UI components to the real workspace they belong to. Update both the authoring reference and the user-facing guide, with the matching shipped skill fingerprint.
Why
A real production iteration exposed two opposite failure modes: a sequence of authentic full-page screenshots still read like slides, while a component-only revision lost the overall product experience. Reducing copy also removed explanations the viewer needed. A later background revision needed changes to both scene styles and timeline color tweens.
The existing guidance already permits rebuilding the moving part and pulling back into the product. This makes that advice actionable without inventing product interactions or prescribing new timing defaults.
Related work
Searched open PRs for overlapping launch/workspace/close-up guidance; none found. This is a self-contained documentation clarification, with no separate issue, runtime/API changes, new catalog items, or generated catalog artifacts.
How
skills-manifest.jsonto match the edited reference.Test plan
bun run lint:skills— skill lint, cross-references and core budgets pass.node scripts/check-skill-mirror.mjs— mirrors match.bun packages/cli/scripts/gen-skills-manifest.ts --check— all seven skills are in sync.oxfmt --check skills/hyperframes/references/types/launch.md skills-manifest.json— passes. MDX is outside the formatter's matched files; reviewed the MDX diff manually.node scripts/check-comment-citations.mjs,node scripts/comment-ratchet.mjs, andgit diff --check— pass.mint broken-links— no broken links.mint validate— full documentation build validation passed.oxlinthas no applicable source files in this diff.