Repository navigation
fix(core): picker labels honour data-label, then an image's alt - #4727
Closed
vanceingalls wants to merge 1 commit into
Closed
vanceingalls wants to merge 1 commit into
vanceingalls wants to merge 1 commit into
Conversation
2 of 4 tasks
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
vanceingalls
force-pushed
the
vance/picker-label-data-label
branch
from
September 29, 2026 15:32
4ce325d to
2f9dc7b
Compare
12 tasks done
2 of 3 tasks
Contributor
|
This PR has had no activity for 14 days, so it is marked stale and will close in 7 days. Push a commit or leave a comment to keep it open. A maintainer can add |
Collaborator
|
Closing under the new stale policy (no activity for 3+ weeks), so the work is free for someone else to pick up. Reopen it, or open a new PR, whenever you pick it back up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The element picker's label for a picked element now uses the element's own
data-labelfirst, and an<img>'salttext before falling back to "Image".Why
The desktop app's new Cut out / Remove from picture feature writes cutout layers named in
data-label(e.g. "Player cutout") and pictures withalttext. Picking one of them in Studio or the desktop preview showed a bare "Image", while the timeline already shows the author's name. The picker and the timeline now agree.Related work
@hyperframes/corepin gets bumped so picks read the cutout's name.How
buildElementLabelreadsdata-label(whitespace-collapsed, trimmed to the existing 56-character cap) before any tag-based rule; forimgit usesaltthe same way, then "Image".Test plan
packages/core/src/runtime/picker.test.ts(data-label wins for any tag, alt names an image, blank values fall back, long values are trimmed) — 47/47 pass🤖 Generated with Claude Code