Repository navigation
fix(render): probe runtime media source mutations - #3729
Merged
Merged
Conversation
Contributor
Fallow audit reportFound 11 findings. Duplication (10)
Health (1)
Generated by fallow. |
miga-heygen
approved these changes
Sep 8, 2026
miga-heygen
left a comment
miga-heygen
left a comment
Contributor
There was a problem hiding this comment.
Reviewed: AST-based extractMediaSrcMutations correctly detects .src assignment and setAttribute on statically-resolvable DOM lookups, scoped to video/audio/source tags. Probe reconciliation and lint paths both wired. Tests thorough. — Miga
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Known-duration compositions now launch the browser reconciliation probe when inline JavaScript synchronously mutates the source of an existing video, audio, or nested
<source>. Extraction, video-frame injection, and audio mixing therefore receive the browser-live source instead of silently retaining the static fallback.An AST-backed
media_runtime_src_mutationwarning identifies literal.src = …andsetAttribute("src", …)writes tied to statically resolvable managed media. It recommends a final static source or declareddata-var-src; image and script source mutations are excluded. The warning remains useful for delayed or external mutations that a pre-extraction probe cannot guarantee.Validation
The sanitized reconciliation fixture uses distinct SHA-256 identities:
986b0b8e67d317608d3edba09b7cdc49afb8237df7e4c7624b766f5d6e0951ac4f250966375ee944833a5633af41005817fd3dffd8975bf16d13f7e3bc3feb09ec6b554699634f58f2783bfdf8345d3280c7217010b932564ea8c3c140f6093528d1a173cb73315c777ac2970cb402267dae4661cb26863d02ad700bd3be469eThe test starts with A in compiled metadata, discovers B from the browser, and proves B reaches media preflight for both video and audio. Original-project preview/output hash verification remains unavailable because the private assets and output were not supplied.