Repository navigation
fix(lint): warn on undefined GSAP color variables - #3723
Merged
Merged
Conversation
miga-heygen
approved these changes
Sep 8, 2026
miga-heygen
left a comment
miga-heygen
left a comment
Contributor
There was a problem hiding this comment.
Reviewed: gsap_undefined_css_variable correctly checks color properties for var() references without fallback or static definition. Respects composition-variable declarations and inline styles. Tests cover all paths. — Miga
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Static lint now warns when a GSAP color-like tween uses
var(--name)without a fallback and no definition can be found in authored CSS ordata-composition-variables. This points authors to the source of text that can become invalid or transparent before the existing browser check reports only the generictext_not_paintedsymptom.The warning checks both
fromToendpoints and color,*Color, fill, and stroke properties. It remains silent for style-block and inline custom-property definitions,var()fallbacks, and composition variables that runtime exposes as--<id>.The reported Whisper behavior is intentionally excluded. The packed v0.8.29 CLI already exits 1 when the required engine is unavailable and 0 only with
--optional; changing that contract would regress working behavior.Validation