Skip to content

fix(lint): flag autoAlpha on clip elements - #3692

Merged
miga-heygen merged 1 commit into
mainfrom
magi/fix-clip-autoalpha-lint
Sep 8, 2026
Merged

miga-heygen merged 1 commit into
mainfrom
magi/fix-clip-autoalpha-lint

Conversation

@miguel-heygen

Copy link
Copy Markdown
Collaborator

What

  • Report gsap_animates_clip_element when GSAP animates autoAlpha on a framework-owned .clip element.
  • Keep autoAlpha animations on descendants valid.

Why

GSAP autoAlpha writes both opacity and visibility. On a scene root it can override the framework's clip visibility window and leave a blank boundary frame, even though the fractional scene windows themselves are gap-free.

How

  • Add autoAlpha to the existing clip visibility conflict check.
  • Clarify the diagnostic and fix hint to explain the visibility conflict.
  • Cover both the invalid clip-root target and valid child target.

Test plan

  • RED/GREEN focused autoAlpha regression tests.
  • Full GSAP lint-rule suite: 167 passed.
  • Lint package typecheck.
  • Oxlint and formatting checks on changed files.

@miga-heygen miga-heygen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean addition — autoAlpha writes both opacity and visibility, so it belongs in the clip-element guard alongside the existing visibility/display checks. Tests cover both the positive and negative cases. — Miga

@miga-heygen
miga-heygen enabled auto-merge (squash) September 8, 2026 18:09
@miga-heygen
miga-heygen merged commit 6c0ee41 into main Sep 8, 2026
46 of 47 checks passed
@miga-heygen
miga-heygen deleted the magi/fix-clip-autoalpha-lint branch September 8, 2026 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants