Skip to content

fix(skills): accept durationless transition roots - #3683

Merged
miga-heygen merged 1 commit into
mainfrom
magi/fix-transition-root-duration
Sep 8, 2026
Merged

miga-heygen merged 1 commit into
mainfrom
magi/fix-transition-root-duration

Conversation

@miguel-heygen

Copy link
Copy Markdown
Collaborator

What

Product-launch and PR-to-video transition injection now accepts a valid frame root without data-duration, inserts the outgoing transition target duration, and continues. A genuinely missing or mismatched composition root still fails hard.

Why

Composition root duration is optional and can be derived from its timeline. Both injectors checked duration before composition identity, so a durationless but correctly identified worker frame was skipped and then misreported as missing data-composition-id.

How

Both workflows now use the already-settled faceless-explainer ordering: identify the matching root first, replace its duration when present, or insert the target duration when absent. Non-root timed elements retain the existing tail-extension rules.

Test plan

  • Product-launch inserts 3.5 seconds on a valid durationless outgoing root.
  • PR-to-video inserts 3.5 seconds on the identical fixture.
  • Both workflows retain the hard failure for a mismatched root.
  • Shared transition regression passes (4/4).
  • Existing PR-to-video frame-contract suite passes (9/9).
  • Node syntax, oxlint, and oxfmt checks pass.
  • Documentation updated (not applicable).

@miga-heygen miga-heygen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good edge case fix — a valid frame root without data-duration should get the attribute inserted rather than bailing. The reorder of the duration/composition match checks is clean. Regression test covers both the fix and the existing rejection path. — Miga

@miga-heygen
miga-heygen enabled auto-merge (squash) September 8, 2026 18:09
@miga-heygen
miga-heygen merged commit 78dacc8 into main Sep 8, 2026
44 of 45 checks passed
@miga-heygen
miga-heygen deleted the magi/fix-transition-root-duration branch September 8, 2026 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants