Repository navigation
fix(cli): reject confirmed unsupported SDR encoders - #3679
Merged
Merged
Conversation
miga-heygen
approved these changes
Sep 8, 2026
miga-heygen
left a comment
miga-heygen
left a comment
Contributor
There was a problem hiding this comment.
Typed H264EncoderUnavailableError correctly gates early rejection to force-sdr MP4 only, leaving HDR/WebM/PNG paths through. Tests cover all format and mode combinations. — Miga
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
An explicitly SDR MP4 render now stops before loading the producer when FFmpeg confirms that the required H.264 encoder is unavailable.
Why
The preflight catch treated a definitive unsupported-encoder result as an inconclusive probe and continued. That wasted rendering work before the same failure surfaced later.
Related: #2735
How
Distinguish confirmed encoder absence with a typed error. Keep unknown/probe-timeout results advisory. Restrict early rejection to forced SDR: auto and HDR may select HEVC after inspecting source media, so this preflight cannot safely reject those paths.
Test plan
Post-Deploy Monitoring & Validation
On the next unsupported forced-SDR render, expect an actionable encoder error before capture begins. Auto/HDR and inconclusive probes retain fallback behavior. Revert this classification if valid supported encoders are rejected.