Repository navigation
fix(shader): keep shader handles within their WebGL context - #3672
Merged
Merged
Conversation
miga-heygen
approved these changes
Sep 8, 2026
miga-heygen
left a comment
miga-heygen
left a comment
Contributor
There was a problem hiding this comment.
Removing the module-level cached vertex shader fixes cross-context handle reuse. The existing createProgramWithVertex already creates both shaders fresh. Test confirms multi-context safety. — Miga
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Shader transitions now initialize correctly when a second WebGL context is created.
Why
A module-global vertex shader belonged to the first context. Reusing it in another context failed program linking. The old lifecycle rewrite is unnecessary for this specific defect.
Related: #3005
How
Use the existing per-context program creation helper instead of caching a shader globally. Context-loss handling and lazy allocation are unchanged.
Test plan
Post-Deploy Monitoring & Validation
On the next shader integration run, exercise two independently mounted contexts and watch for program-link failures. Expected: both render. Revert this narrow helper change if a new initialization regression appears.