Repository navigation
fix(render): allow resolution scaling for alpha output - #3634
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Alpha WebM, MOV, and PNG-sequence renders can now use
--resolutionsupersampling when the requested scale is compatible with the composition.Why
The alpha capture path already applies
deviceScaleFactorthrough the CDP screenshot clip. A stale shared validator still rejected every alpha and output-resolution combination, forcing callers to stage and downscale frames outside HyperFrames.How
Remove the obsolete alpha incompatibility gate while preserving the existing HDR, aspect-ratio, downsampling, and integer-scale checks. Update parser, CLI preflight, and producer regression expectations to cover the supported alpha path.
Test plan
bun test packages/parsers/src/outputResolutionCompatibility.test.ts(12 passed, 0 failed)The full workspace suites could not start locally because the frozen dependency install omitted published
dist/payloads for several packages, including Vitest, oxlint, acorn, and pretext.git diff --checkand a direct Bun bundle of the changed validator passed.