Repository navigation
fix(studio): resolve Chrome on Windows - #2878
Merged
Merged
Conversation
dahans-msft2
pushed a commit
to dahans-msft2/hyperframes
that referenced
this pull request
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Make Studio thumbnail browser discovery support standard Windows Chrome installations and make the browser-launch retry test independent of host-specific Chrome paths.
Why
The Windows test job on
mainfailed becausefindSystemChrome()only knew macOS and Linux locations. The retry test therefore returned before Puppeteer launch on Windows and never exercised the launch-failure retry path. The same omission could prevent standalone Studio/Vite flows from finding an installed Windows Chrome unless an explicit browser override was set.Failed job: https://github.com/heygen-com/hyperframes/actions/runs/30447512847/job/90561714046
How
HYPERFRAMES_BROWSER_PATH/PRODUCER_HEADLESS_SHELL_PATHoverrides first.Test plan
Validation:
bun run --cwd packages/studio test vite.browser.test.ts— 3 passedbun run --cwd packages/studio test— 3,118 passed, 18 todobun run --cwd packages/studio typecheckbunx oxfmt --check packages/studio/vite.browser.ts packages/studio/vite.browser.test.tsbunx oxlint packages/studio/vite.browser.ts packages/studio/vite.browser.test.ts