Skip to content

fix(studio): resolve Chrome on Windows - #2878

Merged
miguel-heygen merged 1 commit into
mainfrom
fix/windows-thumbnail-launch-test-isolation
Jul 29, 2026
Merged

miguel-heygen merged 1 commit into
mainfrom
fix/windows-thumbnail-launch-test-isolation

Conversation

@miguel-heygen

Copy link
Copy Markdown
Collaborator

What

Make Studio thumbnail browser discovery support standard Windows Chrome installations and make the browser-launch retry test independent of host-specific Chrome paths.

Why

The Windows test job on main failed because findSystemChrome() only knew macOS and Linux locations. The retry test therefore returned before Puppeteer launch on Windows and never exercised the launch-failure retry path. The same omission could prevent standalone Studio/Vite flows from finding an installed Windows Chrome unless an explicit browser override was set.

Failed job: https://github.com/heygen-com/hyperframes/actions/runs/30447512847/job/90561714046

How

  • Resolve Chrome from standard Windows Program Files, Program Files (x86), and per-user LocalAppData locations.
  • Keep explicit HYPERFRAMES_BROWSER_PATH / PRODUCER_HEADLESS_SHELL_PATH overrides first.
  • Give the retry test an explicit known executable so it tests retry behavior rather than the CI image filesystem.
  • Add a platform-injected regression test for the standard Windows Chrome path.

Test plan

  • Unit tests added/updated
  • Manual testing performed
  • Documentation updated (not applicable)

Validation:

  • bun run --cwd packages/studio test vite.browser.test.ts — 3 passed
  • bun run --cwd packages/studio test — 3,118 passed, 18 todo
  • bun run --cwd packages/studio typecheck
  • bunx oxfmt --check packages/studio/vite.browser.ts packages/studio/vite.browser.test.ts
  • bunx oxlint packages/studio/vite.browser.ts packages/studio/vite.browser.test.ts
  • pre-commit hooks: tracked artifacts, lint, format, fallow, typecheck

@miguel-heygen
miguel-heygen merged commit d8d6265 into main Jul 29, 2026
43 checks passed
@miguel-heygen
miguel-heygen deleted the fix/windows-thumbnail-launch-test-isolation branch July 29, 2026 15:31
dahans-msft2 pushed a commit to dahans-msft2/hyperframes that referenced this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant