Repository navigation
lint: add tests for three caption rules that have none #5388
Description
Problem
These lint rules have no test that mentions their code, so a change that breaks them would go unnoticed:
| Code | Severity | Defined at |
|---|---|---|
caption_transcript_not_inline |
error | packages/lint/src/rules/captions.ts:90 |
caption_textshadow_on_group_container |
warning | packages/lint/src/rules/captions.ts:171 |
caption_fittext_scale_mismatch |
warning | packages/lint/src/rules/captions.ts:212 |
Tests go in packages/lint/src/rules/captions.test.ts.
Proposed solution
Add tests to the matching *.test.ts file next to each rule, following the style of the other tests in that file. For each rule, add at least:
- one composition that triggers the finding, asserting the code and severity, and
- one similar composition that should not trigger it.
Read the rule's code first: the condition it checks tells you what the minimal triggering composition looks like.
Acceptance criteria
- Each code above is asserted by at least one positive and one negative test.
bun run --cwd packages/lint testpasses.- No rule behaviour changes. If writing a test shows a rule misbehaving, note it in the PR or open a separate issue rather than changing the rule in the same PR.
Activity
test(lint): cover three caption rules that had no tests
lbianlbian commentedon Oct 12, 2026
I'm claiming this issue for my CS 146S OSS contribution assignment.
test(lint): pin the caption CSS gate on the group textShadow rule
test(lint): cover three caption rules that had no tests
test(lint): pin the caption CSS gate on the group textShadow rule
test(lint): cover three caption rules that had no tests (heygen-com#5436
lbianlbian commentedon Oct 28, 2026
Commenting that I'll still take this issue for my required second CS 146S OSS contribution. As stated in the slack channel, the team will prioritize merging Stanford PRs.
test(lint): cover caption transcript, textShadow and fitText rules
jrusso1020 commentedon Nov 5, 2026
Fixed in #5436, released in v0.8.206. Reopen if a case is still missing.