Skip to content

Commit dffc640

Browse files
jrusso1020claude
jrusso1020
and
claude
authored
fix(cli): drop --page-motion-blur from cloud render (#7062)
* fix(cli): drop --page-motion-blur from cloud render The flag sent page_motion_blur to the hosted render API, which never accepted that field and rejects unknown fields. Motion blur is set in the composition with data-motion-blur, and the runtime turns it off on its own when it cannot render correctly, so the cloud flag is removed with its request plumbing, test and docs row. Local render keeps its own --page-motion-blur flag. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> * chore(ci): allow deleting the cloud render page motion blur test The deletion guard blocks removed files unless they are listed. The test file only covered the cloud render --page-motion-blur flag that this branch removes. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> --------- Co-authored-by: Claude Opus 5.5 (1M context) <[email protected]>
1 parent 0f85af7 commit dffc640

4 files changed

Lines changed: 4 additions & 64 deletions

File tree

‎docs/packages/cli.mdx‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2432,7 +2432,6 @@ Render parameters mirror local `hyperframes render` where they overlap:
24322432
| `--fps` | `30` | Integer, 1–240 |
24332433
| `--quality` | `standard` | `draft`, `standard`, or `high` |
24342434
| `--format` | `mp4` | `mp4`, `webm`, or `mov` |
2435-
| `--page-motion-blur` | current cloud behavior | Pass `off` to disable authored page motion blur. Omit to preserve current behavior. Sends the public API field `page_motion_blur: "off"`. |
24362435
| `--resolution` | `1080p` | `1080p` or `4k`. 4k bills at 1.5×. |
24372436
| `--aspect-ratio` | auto | `16:9`, `9:16`, or `1:1`. Auto-detected from a local project's `data-width` and `data-height`, so you rarely need it. The renderer cannot reshape a composition — a value that disagrees with the authored ratio is an error. With `--asset-id` or `--url` the server defaults to `16:9`. |
24382437
| `--composition` / `-c` | `index.html` | Entry HTML file inside the zip |

‎packages/cli/src/commands/cloud/render.pageMotionBlur.test.ts‎

Lines changed: 0 additions & 52 deletions
This file was deleted.

‎packages/cli/src/commands/cloud/render.ts‎

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -127,11 +127,6 @@ export default defineCommand({
127127
},
128128
quality: { type: "string", description: "draft | standard | high (default: standard)" },
129129
format: { type: "string", description: "mp4 | webm | mov (default: mp4)" },
130-
"page-motion-blur": {
131-
type: "string",
132-
description:
133-
"Set off to disable authored page motion blur. Omit to keep the current cloud behavior.",
134-
},
135130
resolution: {
136131
type: "string",
137132
description: "Resolution tier: 1080p | 4k (default: 1080p; 4k is billed at 1.5x)",
@@ -227,9 +222,6 @@ export default defineCommand({
227222
const asJson = Boolean(args.json);
228223
const quality = parseEnumFlag(args.quality, VALID_QUALITY, { flag: "--quality" });
229224
const format = parseEnumFlag(args.format, VALID_FORMAT, { flag: "--format" });
230-
const pageMotionBlur = parseEnumFlag(args["page-motion-blur"], ["off"] as const, {
231-
flag: "--page-motion-blur",
232-
});
233225
const resolution = parseEnumFlag(args.resolution, VALID_RESOLUTION, {
234226
flag: "--resolution",
235227
});
@@ -309,7 +301,6 @@ export default defineCommand({
309301
quality,
310302
format,
311303
resolution,
312-
pageMotionBlur,
313304
aspectRatio,
314305
composition: args.composition,
315306
variables,
@@ -842,7 +833,6 @@ interface SubmitOptions {
842833
fps: number | undefined;
843834
quality: "draft" | "standard" | "high" | undefined;
844835
format: "mp4" | "webm" | "mov" | undefined;
845-
pageMotionBlur: NonNullable<CreateHyperframesRenderRequest["page_motion_blur"]> | undefined;
846836
resolution: CreateHyperframesRenderRequest["resolution"] | undefined;
847837
aspectRatio: CreateHyperframesRenderRequest["aspect_ratio"] | undefined;
848838
composition: string | undefined;
@@ -880,7 +870,6 @@ function buildRenderBody(opts: SubmitOptions): RenderRequestBody {
880870
if (opts.fps !== undefined) body.fps = opts.fps;
881871
if (opts.quality !== undefined) body.quality = opts.quality;
882872
if (opts.format !== undefined) body.format = opts.format;
883-
if (opts.pageMotionBlur !== undefined) body.page_motion_blur = opts.pageMotionBlur;
884873
if (opts.resolution !== undefined) body.resolution = opts.resolution;
885874
if (opts.aspectRatio !== undefined) body.aspect_ratio = opts.aspectRatio;
886875
if (opts.composition !== undefined) body.composition = opts.composition;

‎scripts/check-no-main-deletions.mjs‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2123,6 +2123,10 @@ export const ALLOWED_DELETIONS = new Map([
21232123
"skills/remotion-to-hyperframes/scripts/render_diff.sh",
21242124
"remotion-to-hyperframes now compares with `hyperframes diff` instead of its own shell scripts",
21252125
],
2126+
[
2127+
"packages/cli/src/commands/cloud/render.pageMotionBlur.test.ts",
2128+
"tests for the removed cloud render --page-motion-blur flag; the hosted render API never accepted the field",
2129+
],
21262130
]);
21272131

21282132
export function parseBase(argv, fallback = "origin/main") {

0 commit comments

Comments
 (0)