Skip to content

Commit dd9c86d

Browse files
vanceingallsclaude
andcommitted
docs: correct the --hf-color-grading-intensity claim
Both pages said intensity does not scale a grade and that 0.5 renders the same as 0. That is wrong, and the error was mine: I tested intensity only against twoInkPrint and tapeDamage, then generalised from an effects-only result. The shader mixes ungraded against graded at u_intensity (runtime/colorGrading.ts:1234), so it does scale adjust, wheels, curves, hueCurves, secondaries and the LUT. Runtime tests pin 0.25 and 0.75 reaching the uniform. What it does not scale is details and effects — grain, filmArtifacts, monoScreen, engraving, crosshatch, halftone, twoInkPrint and the tape/CRT families are all applied after that mix (:1235-1262), which is exactly what I had measured. Both pages now say intensity ramps the primary grade only, and to animate the specific effect when the look is effect-based. Reported by miguel-heygen. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
1 parent e4eac0c commit dd9c86d

2 files changed

Lines changed: 8 additions & 4 deletions

File tree

‎docs/guides/color-grading.mdx‎

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -268,9 +268,13 @@ just the endpoints.
268268

269269
Two things this list does **not** give you:
270270

271-
- **`--hf-color-grading-intensity` does not scale a grade at render time.**
272-
Setting it to `0.5` renders the same as `0`, and animating `0 → 1` produces no
273-
change. Do not reach for it as a generic "ramp the whole look" dial.
271+
- **`--hf-color-grading-intensity` scales the primary grade only.** The shader
272+
mixes between the ungraded sample and the graded one at that value, so it
273+
ramps `adjust`, `wheels`, `curves`, `hueCurves`, `secondaries` and the LUT.
274+
It does **not** touch `details` or `effects` — grain, vignette, halftone,
275+
twoInkPrint, bloom, the tape and CRT families are all applied *after* that
276+
mix. So it is not a master "ramp the whole look" dial when the look is
277+
effect-based; animate the specific effect instead.
274278
- **Every other property — `halftone`, `twoInkPrint`, `tapeDamage`, hue curves,
275279
secondaries — has no custom property**, so it cannot be tweened this way.
276280

‎docs/prompting/color-grading.mdx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ Nine properties expose a CSS custom property and tween directly — `ascii`, `bl
159159

160160
Two caveats worth knowing before you promise a client a ramp:
161161

162-
- **`--hf-color-grading-intensity` does not scale a grade at render time.** A static `0.5` renders the same as `0`. Do not reach for it as a generic "ramp the whole look" dial.
162+
- **`--hf-color-grading-intensity` scales the primary grade only** — `adjust`, `wheels`, `curves`, `hueCurves`, `secondaries` and the LUT. It does *not* scale `details` or `effects`, which are applied after that mix, so it will not ramp grain, halftone, bloom or the tape and CRT families. Reach for the specific effect instead of treating it as a master dial.
163163
- **Everything else has no custom property.** Some of those can still be animated by rewriting the `data-color-grading` payload from the timeline, and some cannot — the verified list of which is which lives in the guide's [Animating a Grade](/guides/color-grading#animating-a-grade), so it only has to be maintained in one place. Measure the effect you intend to animate before you promise a ramp, and fall back to a static treatment if it does not move.
164164

165165
## Next steps

0 commit comments

Comments
 (0)