Skip to content

Commit d3a4e90

Browse files
fix(skills): stop embedded-captions shipping author-only paths; dedupe slideshow (#3225)
* fix(skills): stop embedded-captions shipping author-only paths The skill is distributed via `hyperframes skills` (--copy, so the installed bundle matches the published tree), but three shipped files pointed at directories that only exist on the original author's machine. - references/test-set.md: deleted. Nothing in the skill referenced it (zero inbound links across all 140 files), and its corpus lives at ~/Downloads/heygen_relevant_videos/, so it was neither reachable nor runnable. - SKILL.md / dna/README.md: the retired 54-template archive was stated as living at a ~/Downloads path. Keeps the fact, drops the false location. - themes/PORTING.md: marked maintainer-only. It authors new theme DNAs rather than using the skill, nothing links it, and its inputs (the cap_fx3 demos, the frame corpora, CONTRACT.md) are not distributed. The paths stay as the author's original layout, now explicitly labelled as names for the inputs. The 10 references to ~/Downloads/hyperframes are untouched: those are the documented last resort in a real chain (HYPERFRAMES_ROOT -> in-repo -> that path), and every file carrying it also carries the env var. Regenerates skills-manifest.json, which hashes the whole skill directory. Closes #3219 — Rames Jusso (James's assistant) * fix(skills): delete themes/PORTING.md instead of marking it internal Nothing in the skill referenced it, its inputs are not distributed, and git history keeps it recoverable. Marking a dead procedure still ships the dead procedure. — Rames Jusso (James's assistant) * fix(skills): remove duplicated media-cleanup block in slideshow The media-cleanup and global-nav-mute sections appeared twice in skills/slideshow/SKILL.md. The two copies were not identical: the later one was missing the paragraph requiring custom media controls to sync through media events. Deletes the incomplete copy, keeps the complete one. Originally authored in #3218. Carried here re-signed because the org requires signed commits and both changes regenerate skills-manifest.json, which would otherwise conflict between the two PRs. Co-authored-by: Lance Curtis <[email protected]> * chore(skills): regenerate manifest for slideshow + embedded-captions — Rames Jusso (James's assistant) * chore(skills): record the two embedded-captions deletions in the guard check-no-main-deletions.mjs deliberately has no blanket override, so each intentional deletion is named with its reason and shows up in review. — Rames Jusso (James's assistant) --------- Co-authored-by: Lance Curtis <[email protected]>
1 parent 7860d19 commit d3a4e90

7 files changed

Lines changed: 14 additions & 150 deletions

File tree

‎scripts/check-no-main-deletions.mjs‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,14 @@ export const ALLOWED_DELETIONS = new Map([
4141
"packages/studio/src/components/StudioFeedbackBar.tsx",
4242
"replaced by components/feedback/StudioFeedbackCard.tsx; too little shared content for git to pair as a rename",
4343
],
44+
[
45+
"skills/embedded-captions/references/test-set.md",
46+
"#3219: orphaned in the shipped skill (zero inbound references across all 140 files) and its corpus lives only at ~/Downloads/heygen_relevant_videos/, so it was neither reachable nor runnable on any install",
47+
],
48+
[
49+
"skills/embedded-captions/themes/PORTING.md",
50+
"#3219: same, zero inbound references; a theme-authoring procedure whose inputs (cap_fx3 demos, frame corpora, CONTRACT.md) are not distributed with the skill",
51+
],
4452
]);
4553

4654
export function parseBase(argv, fallback = "origin/main") {

‎skills-manifest.json‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
"source": "heygen-com/hyperframes",
33
"skills": {
44
"embedded-captions": {
5-
"hash": "e8c2c3b6dfd04b39",
6-
"files": 140
5+
"hash": "14e79d53c24e3945",
6+
"files": 138
77
},
88
"faceless-explainer": {
99
"hash": "c70b904aa68cf7e5",
@@ -70,7 +70,7 @@
7070
"files": 70
7171
},
7272
"slideshow": {
73-
"hash": "71368acf61074198",
73+
"hash": "6a24a84b0c1a75f9",
7474
"files": 2
7575
},
7676
"talking-head-recut": {

‎skills/embedded-captions/SKILL.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ Pick by `safe-zones.json` (`heroAnchor.bandLuma`, `palette.temperature`) × cont
174174

175175
The engine generates the **hero three-act** from the DNA (no authoring needed): co-visible captions dim (setup) → per-letter entrance with amplitude ∝ spoken loudness (impact) → breathe + glow until exit (afterglow).
176176

177-
(Legacy: `plan.template:"cinematic-cream"` maps to `dna:"cream"` automatically. The retired 54-template library lives outside the skill at `~/Downloads/embedded-captions-archive/standard-templates-54/`; `_motion.md` remains in-skill as the motion-verb reference catalog.)
177+
(Legacy: `plan.template:"cinematic-cream"` maps to `dna:"cream"` automatically. The retired 54-template library is archived outside this repo and is not distributed with the skill; `_motion.md` remains in-skill as the motion-verb reference catalog.)
178178

179179
---
180180

‎skills/embedded-captions/dna/README.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ shallow presets — every render is already fitted to its footage.
1313

1414
Every classic DNA's **home is Cinematic (column)** — that is where all ten were
1515
built and validated. (Standard/rail mode was retired 2026-06-12; the verbatim-rail
16-
need is served by the `anchor` theme. The old rail combos live in
17-
`~/Downloads/embedded-captions-archive/`.)
16+
need is served by the `anchor` theme. The old rail combos are archived outside
17+
this repo and are not distributed with the skill.)
1818

1919
## The ten
2020

‎skills/embedded-captions/references/test-set.md‎

Lines changed: 0 additions & 66 deletions
This file was deleted.

‎skills/embedded-captions/themes/PORTING.md‎

Lines changed: 0 additions & 48 deletions
This file was deleted.

‎skills/slideshow/SKILL.md‎

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -460,36 +460,6 @@ The same cross-realm rule applies here: global mute must reach iframe `<video>`
460460

461461
`hyperframes present` serves built bundles from `packages/player/dist`. After changing player or slideshow chrome behavior, run `bun run build` in `packages/player` and restart the present server before testing in a browser.
462462

463-
Presenter notes are editable in the presenter view. Edits are stored in `localStorage` per deck and slide, layered over the manifest notes without rewriting the composition file. Do not add one-off note-editing scripts to decks; rely on the shared slideshow player behavior. If a standalone/custom wrapper truly needs to implement this outside the shared player, use the deterministic storage snippet in `skills/slideshow/references/standalone-harness.md`.
464-
465-
### Media cleanup on slide exit
466-
467-
The slideshow controller owns slide-exit media cleanup. When navigation changes slide or sequence, it calls `hyperframes-player.stopMedia()` before entering the next slide. That command:
468-
469-
- posts `stop-media` to the iframe runtime, which stops WebAudio and pauses native `<video>` / `<audio>` elements;
470-
- pauses same-origin iframe media directly as a fallback; and
471-
- pauses parent-frame proxies adopted from iframe media.
472-
473-
Same-slide fragment navigation does **not** stop media. Global/deck-level parent audio, such as a background track wired through `audio-src`, is not treated as slide media.
474-
475-
Do not add per-slide cleanup scripts for normal media players. Keep slide video/audio as normal media in the composition; use `data-has-audio="true"` only when the player should preserve audible native video audio instead of treating it as silent visual media.
476-
477-
When implementing direct iframe fallback cleanup, treat iframe media as cross-realm DOM. Do not test iframe nodes with the parent page's `el instanceof HTMLMediaElement`; that returns false in real browsers. Use `el.ownerDocument.defaultView.HTMLMediaElement` (or an equivalent tag/duck-type guard) before setting `muted` or calling `pause()`.
478-
479-
### Global nav mute
480-
481-
When `<hyperframes-slideshow sound>` renders the nav mute button, that button is the global mute control for the page. It must mute:
482-
483-
- child `<hyperframes-player>` instances, including same-origin iframe media;
484-
- top-level page `<audio>` / `<video>` elements; and
485-
- wrapper-owned SFX/global `Audio` objects via the `hf-sound` event.
486-
487-
Do not add a second mute button inside the composition. If a wrapper script creates `new Audio(...)` objects that are not attached to the DOM, it must listen for `hf-sound` and set `clip.muted = detail.muted` on each object, not merely skip future plays.
488-
489-
The same cross-realm rule applies here: global mute must reach iframe `<video>` / `<audio>` elements through the child frame's DOM realm. A passing unit test in a single DOM realm is not enough; verify in a browser that the actual iframe media elements report `muted: true` after clicking the nav mute button.
490-
491-
`hyperframes present` serves built bundles from `packages/player/dist`. After changing player or slideshow chrome behavior, run `bun run build` in `packages/player` and restart the present server before testing in a browser.
492-
493463
---
494464

495465
## Running a slideshow standalone (interim)

0 commit comments

Comments
 (0)