You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit d1482b0
Browse filesBrowse the repository at this point in the historyBrowse files
fix(skills): resolve the blueprint id from a qualified blueprint: field (#3337)
* fix(skills): resolve the blueprint id from a qualified `blueprint:` field
visual-design.md documents `blueprint:` as the id plus a `(Reproduce)` /
`(Adapt)` qualifier, and prints `dataviz-countup (Adapt)` as its worked example.
The packet builder used that raw field as a filename, so a qualified blueprint
looked for `<id> (Adapt).md`, found nothing, and inlined an empty string:
`selectedFile()` returns "" for a missing path. Every packet shipped without the
one document the frame was designed against, and the run still exited 0 with
nothing on stderr. `compose (Adapt)` missed the `compose` check the same way.
Parse the field into the id it names, once, so no caller resolves a raw field
value against the blueprints directory. A blueprint that resolves to no file is
now a named error rather than an empty section, matching how the builder already
treats a missing `src` and an oversize packet.
The existing tests only used bare ids, which is how the qualified form escaped;
they now cover both, and the missing-file case.
One owner: product-launch-video, faceless-explainer, pr-to-video and
general-video all delegate to frame-packets-core.mjs.
Co-Authored-By: anikam13 <[email protected]>
* fix(skills): degrade, not fail, when the blueprints library is absent
Self-review catch on the previous commit. hyperframes-animation installs on
demand, so its blueprints/ directory can legitimately be missing — that is a
skill that isn't installed yet, not a frame naming a bad id. Throwing there
turned a silent degrade into a hard failure for a valid setup.
Distinguish the two: an absent blueprints/ warns and inlines nothing, exactly
as an absent rules/ already does in knownRuleIds; a present library that has no
file for this id still throws, because that is a typo or an unstripped
qualifier.
Co-Authored-By: anikam13 <[email protected]>
* fix(skills): point two dead blueprint references at real shapes
CI surfaced these once an unresolvable blueprint stopped being silent. Both
named ids that have never existed in hyperframes-animation/blueprints/:
- faceless-explainer's frame template taught `messaging-multi-phase`, so an
agent copying the template verbatim tagged a blueprint that resolves to
nothing. dataviz-countup is what the same skill already uses in its own
visual-design template and tests.
- pr-to-video's diff-excerpt guardrail fixture used `number-lockup`. The test is
about diff excerpting and the id was incidental; the frame's own
`counting-dynamic-scale` rule makes dataviz-countup the natural real shape.
A sweep of every `blueprint:` value across skills/ finds no others.
Co-Authored-By: anikam13 <[email protected]>
---------
Co-authored-by: anikam13 <[email protected]>
0 commit comments