Skip to content

Commit d012537

Browse files
committed
docs: three things the source contradicts, found by reading the pages
**`bun unlink hyperframes` does not exist.** Bun answers "error: bun unlink {packageName} not implemented yet" — I ran it. The command takes no package name; it unregisters whatever directory you are standing in. The reader arrives at that block having just been told to cd into a video project, so even the correct form would unregister the wrong thing and leave the global link in place — which is exactly the failure the same page's troubleshooting section then explains. The page created the bug it diagnosed. Now `cd packages/cli && bun unlink`. **`data-media-start` and `data-playback-start` are one value, not two features.** The schema page gave them separate rows with different-sounding meanings, so a reader would reasonably think they compose. Six read sites in core are all `playbackStart ?? mediaStart` — runtime/media.ts:18 and :92, runtime/init.ts:751, 1993, 2928, 3010. One row now, alias named, and it says which wins. **Canary rollouts contradicted itself.** Line 109 called enrolment a pure function of `(feature, installId, percentage)`; line 195 said canaries bucket on a dedicated `bucketSeed`, not the telemetry id. The second is right — cli/src/telemetry/canary.ts:98 is `unitId: config.bucketSeed ?? config.anonymousId`. Also on the Studio shortcuts page earlier: J/Shift+J for keyframe navigation, Backspace to delete, and Ctrl+Y for redo were all missing.
1 parent 1a22d65 commit d012537

3 files changed

Lines changed: 7 additions & 5 deletions

File tree

‎docs/contributing/canary-rollouts.mdx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ Two details worth knowing:
106106
## Cumulative exposure — the number that actually bounds blast radius
107107

108108
The instantaneous share holds at the target forever: enrolment is a pure
109-
function of `(feature, installId, percentage)` and fresh ids are uniformly
109+
function of `(feature, bucketSeed, percentage)` and fresh ids are uniformly
110110
random, so ~10% of active installs and ~10% of renders are enrolled on any
111111
given day. That part does not drift.
112112

‎docs/contributing/testing-local-changes.mdx‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,13 @@ hyperframes check
4141
hyperframes preview
4242
```
4343

44-
Remove the link when finished:
44+
Remove the link when finished. `bun unlink` takes no package name — it
45+
unregisters whichever directory you run it from, so go back to the CLI package
46+
first:
4547

4648
```bash
47-
bun unlink hyperframes
49+
cd packages/cli
50+
bun unlink
4851
```
4952

5053
### Call the built entry directly

‎docs/reference/html-schema.mdx‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,8 +122,7 @@ Audio has no visual lifecycle.
122122

123123
| Attribute | Applies to | Meaning |
124124
| --- | --- | --- |
125-
| `data-media-start` | Video and audio | Offset into the source file |
126-
| `data-playback-start` | Video, audio, nested composition | Source-time offset used by trim and split operations |
125+
| `data-playback-start`<br />(alias: `data-media-start`) | Video, audio, nested composition | Offset into the source file, used by trim and split. The two names are one value — `data-playback-start` wins if both are set. |
127126
| `data-playback-rate` | Video, audio, nested composition | Playback multiplier from `0.1` to `5` |
128127
| `data-volume` | Video and audio | Static volume from `0` to `1` |
129128
| `data-has-audio="true"` | Video | Declares that the video contributes audio |

0 commit comments

Comments
 (0)