Repository navigation
Commit cb73c8d
authored
feat(studio): apply a style to a run of characters (#3142)
* feat(studio): apply a style to a run of characters
Styling text in a composition cannot be done by wrapping a DOM range in a
span. That is three lines, and then every interesting case is a special
case: recolouring nests spans that shadow each other, removing a style
cannot reach the ancestor that set it, and styling across an existing run's
boundary has to split it. Each fix is a new branch and the branches
interact.
So the element is read into a flat list of styled runs, the style is applied
to a span of characters in that list, and the element is rebuilt from it.
Replacing, removing, splitting and merging stop being cases: the rebuild
emits one span per distinct run and cannot nest or duplicate, whatever was
there before.
Selection offsets count UTF-16 units, so a boundary can land between the
halves of an emoji; the applied range widens to whole characters. A colour
an ancestor overpaints is mirrored into the fill, because a colour that does
not paint reads to the user as a colour that did not save.
The toolbar that drives this arrives with the editor in the next change.
* fix(studio): harden inline text styling boundaries
* fix(studio): align inline styling with persistence
* test(studio): pin inline identity delimiters1 parent 636dc04 commit cb73c8d
3 files changed
Lines changed: 1309 additions & 3 deletions
File tree
- packages
- core/src/utils
- studio/src/components/editor
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
98 | 98 | | |
99 | 99 | | |
100 | 100 | | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
101 | 115 | | |
102 | 116 | | |
103 | 117 | | |
| |||
165 | 179 | | |
166 | 180 | | |
167 | 181 | | |
168 | | - | |
| 182 | + | |
169 | 183 | | |
170 | 184 | | |
171 | 185 | | |
| |||
182 | 196 | | |
183 | 197 | | |
184 | 198 | | |
185 | | - | |
186 | | - | |
| 199 | + | |
187 | 200 | | |
188 | 201 | | |
189 | 202 | | |
| |||
0 commit comments