Skip to content

Commit c74bb14

Browse files
committed
fix(core): keep the seek-wait comments within the comment limits
1 parent e7c8a3e commit c74bb14

2 files changed

Lines changed: 2 additions & 6 deletions

File tree

‎packages/core/src/runtime/adapters/seek-dispatch.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ describe("seek-dispatch", () => {
214214
await expect(waitForSeekCompletion()).resolves.toBeUndefined();
215215
});
216216

217-
// Fails on main: the barrier had no deadline, so one hold that never settles waited out the caller's protocol timeout.
217+
// Main had no deadline: a hold that never settles waited out the caller's protocol timeout.
218218
it("a seek with a hold that never settles ends at its deadline, naming what it still waits on", async () => {
219219
registerSeekCompletion(new Promise(() => {}), "frame-source");
220220
registerSeekCompletion(Promise.resolve(), "video-frame");

‎packages/core/src/runtime/adapters/seek-dispatch.ts‎

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -142,11 +142,7 @@ async function settledBy(
142142
}
143143
}
144144

145-
/**
146-
* `videoFrames: false` skips only the video-frame holds: a geometry read needs every other completion. A seek that
147-
* has not settled by `timeoutMs` throws, naming the holds it still waits on, so a capture fails with why instead of
148-
* waiting on its caller's protocol timeout.
149-
*/
145+
/** `videoFrames: false` skips only video-frame holds. Past `timeoutMs` it throws, naming the holds still pending. */
150146
export async function waitForSeekCompletion(options?: {
151147
videoFrames?: boolean;
152148
timeoutMs?: number;

0 commit comments

Comments
 (0)