Skip to content

Commit c6be942

Browse files
vanceingallsclaude
andcommitted
test(producer): the real-ffmpeg deferred extraction test moves to the integration lane
Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent 83d4ebc commit c6be942

3 files changed

Lines changed: 102 additions & 58 deletions

File tree

‎packages/producer/scripts/integration-tests.json‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,5 +47,6 @@
4747
"src/utils/audioRegression.test.ts",
4848
"src/utils/streamDurationParity.test.ts",
4949
"src/services/distributed/referenceBackground.integration.test.ts",
50-
"src/services/render/planReferenceBackground.polling.test.ts"
50+
"src/services/render/planReferenceBackground.polling.test.ts",
51+
"src/services/render/deferredVideoFrames.integration.test.ts"
5152
]
Lines changed: 98 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,98 @@
1+
import { spawnSync } from "node:child_process";
2+
import { mkdirSync, mkdtempSync, rmSync } from "node:fs";
3+
import { tmpdir } from "node:os";
4+
import { join } from "node:path";
5+
import { afterAll, beforeAll, describe, expect, it } from "bun:test";
6+
import type { ExtractedFrames, VideoElement } from "@hyperframes/engine";
7+
import { extractDeferredFrames } from "./deferredVideoFrames.js";
8+
9+
const metadata = {
10+
durationSeconds: 4,
11+
videoStreamDurationSeconds: 4,
12+
videoStreamStartSeconds: 0,
13+
width: 64,
14+
height: 36,
15+
fps: 30,
16+
videoCodec: "h264",
17+
hasAudio: false,
18+
isVFR: false,
19+
hasAlpha: false,
20+
colorSpace: null,
21+
};
22+
23+
const deferredVideo = (videoId: string, totalFrames: number): ExtractedFrames => ({
24+
videoId,
25+
srcPath: `/planner/${videoId}.mp4`,
26+
outputDir: "",
27+
framePattern: "frame_%05d.jpg",
28+
fps: 30,
29+
totalFrames,
30+
metadata,
31+
framePaths: new Map(),
32+
deferredRange: { startTime: 1.5, durationSeconds: totalFrames / 30, format: "jpg" },
33+
});
34+
35+
const element = (id: string, start: number, end: number): VideoElement => ({
36+
id,
37+
src: `${id}.mp4`,
38+
start,
39+
end,
40+
mediaStart: 1.5,
41+
loop: false,
42+
hasAudio: false,
43+
});
44+
45+
const fps = { num: 30, den: 1 };
46+
const span = (start: number, end: number) =>
47+
Array.from({ length: end - start }, (_, i) => start + i);
48+
49+
describe("extractDeferredFrames", () => {
50+
const root = mkdtempSync(join(tmpdir(), "hf-deferred-frames-"));
51+
const sourcePath = join(root, "short.mp4");
52+
53+
beforeAll(() => {
54+
mkdirSync(root, { recursive: true });
55+
const synth = spawnSync("ffmpeg", [
56+
"-v",
57+
"error",
58+
"-y",
59+
"-f",
60+
"lavfi",
61+
"-i",
62+
"testsrc2=s=64x36:r=30:d=3",
63+
"-c:v",
64+
"libx264",
65+
"-pix_fmt",
66+
"yuv420p",
67+
sourcePath,
68+
]);
69+
if (synth.status !== 0) throw new Error(synth.stderr.toString());
70+
});
71+
72+
afterAll(() => {
73+
rmSync(root, { recursive: true, force: true });
74+
});
75+
76+
it("calls onMissingFrame when the extractor returns fewer frames than the plan expected", async () => {
77+
const planned = deferredVideo("clip", 75);
78+
const missingError = new Error("plan expected more frames");
79+
const reported: Array<{ videoId: string; index: number }> = [];
80+
81+
const extraction = extractDeferredFrames({
82+
videos: [element("clip", 0, 4)],
83+
extracted: [planned],
84+
frames: span(40, 62),
85+
fps,
86+
outputRoot: join(root, "out"),
87+
cfg: {},
88+
sourceOf: () => sourcePath,
89+
onMissingFrame: (video, index) => {
90+
reported.push({ videoId: video.videoId, index });
91+
return missingError;
92+
},
93+
});
94+
95+
await expect(extraction).rejects.toBe(missingError);
96+
expect(reported).toEqual([{ videoId: "clip", index: 45 }]);
97+
});
98+
});
Lines changed: 2 additions & 57 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
1-
import { spawnSync } from "node:child_process";
2-
import { mkdirSync, mkdtempSync, rmSync } from "node:fs";
3-
import { tmpdir } from "node:os";
4-
import { join } from "node:path";
5-
import { afterAll, beforeAll, describe, expect, it } from "bun:test";
1+
import { describe, expect, it } from "bun:test";
62
import type { ExtractedFrames, VideoElement } from "@hyperframes/engine";
7-
import { extractDeferredFrames, shownDeferredFrameIndexes } from "./deferredVideoFrames.js";
3+
import { shownDeferredFrameIndexes } from "./deferredVideoFrames.js";
84

95
const metadata = {
106
durationSeconds: 4,
@@ -61,54 +57,3 @@ describe("shownDeferredFrameIndexes", () => {
6157
expect(shown.has("later")).toBe(false);
6258
});
6359
});
64-
65-
describe("extractDeferredFrames", () => {
66-
const root = mkdtempSync(join(tmpdir(), "hf-deferred-frames-"));
67-
const sourcePath = join(root, "short.mp4");
68-
69-
beforeAll(() => {
70-
mkdirSync(root, { recursive: true });
71-
const synth = spawnSync("ffmpeg", [
72-
"-v",
73-
"error",
74-
"-y",
75-
"-f",
76-
"lavfi",
77-
"-i",
78-
"testsrc2=s=64x36:r=30:d=3",
79-
"-c:v",
80-
"libx264",
81-
"-pix_fmt",
82-
"yuv420p",
83-
sourcePath,
84-
]);
85-
if (synth.status !== 0) throw new Error(synth.stderr.toString());
86-
});
87-
88-
afterAll(() => {
89-
rmSync(root, { recursive: true, force: true });
90-
});
91-
92-
it("calls onMissingFrame when the extractor returns fewer frames than the plan expected", async () => {
93-
const planned = deferredVideo("clip", 75);
94-
const missingError = new Error("plan expected more frames");
95-
const reported: Array<{ videoId: string; index: number }> = [];
96-
97-
const extraction = extractDeferredFrames({
98-
videos: [element("clip", 0, 4)],
99-
extracted: [planned],
100-
frames: span(40, 62),
101-
fps,
102-
outputRoot: join(root, "out"),
103-
cfg: {},
104-
sourceOf: () => sourcePath,
105-
onMissingFrame: (video, index) => {
106-
reported.push({ videoId: video.videoId, index });
107-
return missingError;
108-
},
109-
});
110-
111-
await expect(extraction).rejects.toBe(missingError);
112-
expect(reported).toEqual([{ videoId: "clip", index: 45 }]);
113-
});
114-
});

0 commit comments

Comments
 (0)