Skip to content

Commit c56e02e

Browse files
committed
fix(engine): renders from the CLI launch the browser it picked, not the engine config's
1 parent 85f4530 commit c56e02e

2 files changed

Lines changed: 23 additions & 1 deletion

File tree

‎packages/engine/src/config.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -852,7 +852,6 @@ export function resolveConfig(overrides?: Partial<EngineConfig>): EngineConfig {
852852
DEFAULT_CONFIG.largeRenderThreshold,
853853
),
854854

855-
chromePath: env("PRODUCER_HEADLESS_SHELL_PATH"),
856855
disableGpu: envBool("PRODUCER_DISABLE_GPU", DEFAULT_CONFIG.disableGpu),
857856
browserGpuMode: envBrowserGpuMode(),
858857
allowSoftwareWebGpu: envBool(

‎packages/engine/src/services/browserManager.test.ts‎

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import type { Browser, Page, PuppeteerNode } from "puppeteer-core";
99

1010
import type { CaptureMode } from "./browserLeasePool.js";
1111
import { managedChromeVersion } from "./chromeHostCeiling.js";
12+
import { resolveConfig } from "../config.js";
1213

1314
import {
1415
_resetAutoBrowserGpuModeCacheForTests,
@@ -818,6 +819,12 @@ describe("resolveHeadlessShellPath", () => {
818819
const originalHeadlessShellPath = process.env.PRODUCER_HEADLESS_SHELL_PATH;
819820
const originalHyperframesBrowserPath = process.env.HYPERFRAMES_BROWSER_PATH;
820821

822+
// A runner may export either var (the Windows job sets HYPERFRAMES_BROWSER_PATH); each case sets its own.
823+
beforeEach(() => {
824+
delete process.env.PRODUCER_HEADLESS_SHELL_PATH;
825+
delete process.env.HYPERFRAMES_BROWSER_PATH;
826+
});
827+
821828
afterEach(() => {
822829
if (originalHeadlessShellPath === undefined) delete process.env.PRODUCER_HEADLESS_SHELL_PATH;
823830
else process.env.PRODUCER_HEADLESS_SHELL_PATH = originalHeadlessShellPath;
@@ -849,6 +856,22 @@ describe("resolveHeadlessShellPath", () => {
849856
}
850857
});
851858

859+
it("keeps that precedence through a render's resolved engine config", () => {
860+
const dir = mkdtempSync(join(tmpdir(), "hyperframes-engine-browser-env-"));
861+
try {
862+
const cliChoice = join(dir, "chosen-browser");
863+
const other = join(dir, "other-browser");
864+
writeFileSync(cliChoice, "");
865+
writeFileSync(other, "");
866+
process.env.HYPERFRAMES_BROWSER_PATH = cliChoice;
867+
process.env.PRODUCER_HEADLESS_SHELL_PATH = other;
868+
869+
expect(resolveHeadlessShellPath(resolveConfig())).toBe(cliChoice);
870+
} finally {
871+
rmSync(dir, { recursive: true, force: true });
872+
}
873+
});
874+
852875
it("uses HYPERFRAMES_BROWSER_PATH when the CLI resolved a browser explicitly", () => {
853876
const dir = mkdtempSync(join(tmpdir(), "hyperframes-engine-browser-env-"));
854877
try {

0 commit comments

Comments
 (0)