@@ -9,7 +9,12 @@ import { closeSync, existsSync, mkdirSync, mkdtempSync, openSync, rmSync, writeF
99import { join , dirname } from "path" ;
1010import { parseHTML } from "linkedom" ;
1111import { extractAudioMetadata } from "../utils/ffprobe.js" ;
12- import { downloadToTemp , isHttpUrl } from "../utils/urlDownloader.js" ;
12+ import {
13+ downloadToTemp ,
14+ isHttpUrl ,
15+ UrlDownloadError ,
16+ writeUrlDownloadTelemetry ,
17+ } from "../utils/urlDownloader.js" ;
1318import { DEFAULT_CONFIG , type EngineConfig } from "../config.js" ;
1419import { formatFfmpegError , runFfmpeg , type RunFfmpegResult } from "../utils/runFfmpeg.js" ;
1520import { unwrapTemplate } from "../utils/htmlTemplate.js" ;
@@ -241,16 +246,23 @@ function probeFailure(message: string, elementId: string): AudioProcessingFailur
241246 } ;
242247}
243248
244- function downloadFailure ( message : string , elementId : string ) : AudioProcessingFailure {
249+ function downloadFailure ( error : unknown , elementId : string ) : AudioProcessingFailure {
250+ const message = error instanceof Error ? error . message : String ( error ) ;
245251 const invalidSource =
246- / (?: i n v a l i d U R L | o n l y H T T P S | p r i v a t e \/ r e s e r v e d | H T T P (?: 4 0 0 | 4 0 1 | 4 0 3 | 4 0 4 | 4 0 5 | 4 1 0 | 4 2 2 ) \b ) / i. test (
247- message ,
248- ) ;
252+ error instanceof UrlDownloadError
253+ ? error . kind === "http_not_found" ||
254+ error . kind === "http_rejected" ||
255+ error . kind === "invalid_payload" ||
256+ error . kind === "cancelled"
257+ : / (?: i n v a l i d U R L | o n l y H T T P S | p r i v a t e \/ r e s e r v e d | H T T P (?: 4 0 0 | 4 0 1 | 4 0 3 | 4 0 4 | 4 0 5 | 4 1 0 | 4 2 2 ) \b ) / i. test (
258+ message ,
259+ ) ;
260+ const retryable = error instanceof UrlDownloadError ? error . retryable : ! invalidSource ;
249261 return {
250262 stage : "download" ,
251263 reason : "download_failed" ,
252264 owner : invalidSource ? "user" : "system" ,
253- retryable : ! invalidSource ,
265+ retryable,
254266 elementId,
255267 detail : boundedDetail ( `Download failed for audio element ${ elementId } : ${ message } ` ) ,
256268 } ;
@@ -712,11 +724,11 @@ export async function processCompositionAudio(
712724
713725 if ( isHttpUrl ( srcPath ) ) {
714726 try {
715- srcPath = await downloadToTemp ( srcPath , workDir ) ;
727+ srcPath = await downloadToTemp ( srcPath , workDir , undefined , signal , undefined , {
728+ onTelemetry : writeUrlDownloadTelemetry ,
729+ } ) ;
716730 } catch ( err : unknown ) {
717- failures . push (
718- downloadFailure ( err instanceof Error ? err . message : String ( err ) , element . id ) ,
719- ) ;
731+ failures . push ( downloadFailure ( err , element . id ) ) ;
720732 return ;
721733 }
722734 }
0 commit comments