Skip to content

Commit b3d2b82

Browse files
feat(core): the renderer's font pipeline is importable from @hyperframes/core/fonts/embed (#5041)
* feat(core): the renderer's font pipeline is importable from @hyperframes/core/fonts/embed * style(core): format the font pipeline and state the bundled-subset invariant * test(producer): repin the test lane map after the font tests moved to core * fix(core): images build fonts once, CLI bundles one pipeline, font tests pass on Windows * test(core): font retry tests get a budget no slow machine can exhaust * test(core): the Retry-After budget test fails when the budget is ignored
1 parent db12b3e commit b3d2b82

40 files changed

Lines changed: 243 additions & 187 deletions

‎.fallowrc.jsonc‎

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
"packages/producer/src/perf-gate.ts",
1919
"packages/producer/src/runtime-conformance.ts",
2020
"packages/producer/src/benchmark.ts",
21-
"packages/producer/scripts/generate-font-data.ts",
21+
"packages/core/scripts/generate-font-data.ts",
2222
"packages/producer/we-render.mjs",
2323
"packages/producer/scripts/validate-fast-video.ts",
2424
"packages/cli/scripts/generate-font-data.ts",
@@ -494,6 +494,16 @@
494494
// new package makes fallow see it as a fresh finding; the underlying clone
495495
// predates this refactor.
496496
"packages/parsers/src/hfIds.ts",
497+
// Font pipeline: pre-existing duplication moved from packages/producer/src/services/
498+
// and producer/scripts/ to core/src/fonts/ and core/scripts/ (the generator mirrors
499+
// CANONICAL_FONTS; the tests share arrange/act scaffolds).
500+
"packages/core/scripts/generate-font-data.ts",
501+
"packages/core/src/fonts/deterministicFonts-aliasSupplement.test.ts",
502+
"packages/core/src/fonts/deterministicFonts-authoredResources.test.ts",
503+
"packages/core/src/fonts/deterministicFonts-failClosed.test.ts",
504+
"packages/core/src/fonts/deterministicFonts-googleSubsets.test.ts",
505+
"packages/core/src/fonts/deterministicFonts-retries.test.ts",
506+
"packages/core/src/fonts/fontCompression.test.ts",
497507
// Parser test files: parallel arrange/act/assert test cases — pre-existing
498508
// duplication moved from packages/core/src/parsers/.
499509
"packages/parsers/src/gsapParser.test.ts",
@@ -733,6 +743,9 @@
733743
// complexity pre-dates the computed-timeline work. Exempted at file level
734744
// rather than refactored as scope creep.
735745
"ignore": [
746+
// generate-font-data.ts: the build-time font data generator moved from producer/scripts;
747+
// its CRAP score is coverage-driven (a build script no unit test runs).
748+
"packages/core/scripts/generate-font-data.ts",
736749
// audio-fx-runtime-entry.ts: the browser-side IIFE entry for the offline FX
737750
// render. It runs only inside the headless page the engine drives, so unit
738751
// coverage cannot reach it and its CRAP score is coverage-driven rather

‎.gitignore‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ tmp/
7575
packages/core/src/generated/*
7676
!packages/core/src/generated/position-edits-render-inline.ts
7777
!packages/core/src/generated/position-edits-render-inline.test.ts
78-
packages/producer/src/services/fontData.generated.ts
78+
packages/core/src/fonts/fontData.generated.ts
7979

8080
# Plan documents (working artifacts, not committed)
8181
docs/plans/

‎Dockerfile.test‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -122,9 +122,6 @@ RUN bun run --filter @hyperframes/core build:hyperframes-runtime:modular
122122
COPY packages/engine/ packages/engine/
123123
COPY packages/producer/ packages/producer/
124124

125-
# Generate embedded font data (deterministicFonts.ts imports this at runtime)
126-
RUN cd packages/producer && bunx tsx scripts/generate-font-data.ts
127-
128125
WORKDIR /app/packages/producer
129126

130127
# Skip fixtures tagged `transparency` (Chrome alpha-channel PSNR quirks not

‎bun.lock‎

Lines changed: 32 additions & 32 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎packages/aws-lambda/scripts/_handlerBanner.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
* assume all three exist at module scope:
77
* - postcss et al. call top-level `require(...)`
88
* - wawoff2's emscripten build (pulled in unconditionally via
9-
* producer → fontCompression) reads `__dirname` at module scope
9+
* producer → core fonts/fontCompression) reads `__dirname` at module scope
1010
* Without the shims the handler throws "Dynamic require of <X> is not
1111
* supported" / "__dirname is not defined in ES module scope" at import time,
1212
* before it can run — which is exactly how a freshly deployed stack crashed

‎packages/cli/scripts/build-fonts.mjs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,13 @@
22
import { existsSync } from "node:fs";
33
import { execSync } from "node:child_process";
44

5-
const target = "../producer/src/services/fontData.generated.ts";
5+
const target = "../core/src/fonts/fontData.generated.ts";
66

77
if (existsSync(target)) {
88
console.log("[build:fonts] skipped — fontData.generated.ts already exists");
99
process.exit(0);
1010
}
1111

12-
execSync("cd ../producer && tsx scripts/generate-font-data.ts", {
12+
execSync("cd ../core && tsx scripts/generate-font-data.ts", {
1313
stdio: "inherit",
1414
});

‎packages/cli/src/server/studioServer.ts‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -499,8 +499,7 @@ export function createStudioServer(options: StudioServerOptions): StudioServer {
499499
},
500500

501501
async transformPreviewHtml({ html, project }) {
502-
const { injectDeterministicFontFaces } =
503-
await import("../../../producer/src/services/deterministicFonts.js");
502+
const { injectDeterministicFontFaces } = await import("@hyperframes/core/fonts/embed");
504503
const { prepareAnimatedGifInputs } =
505504
await import("../../../producer/src/services/animatedGifPrep.js");
506505
const { downloadToTemp, writeUrlDownloadTelemetry } =

‎packages/core/package-subpaths.json‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -482,6 +482,18 @@
482482
"types": "./dist/fonts/systemFontLocator.d.ts",
483483
"environments": ["bun", "node"]
484484
},
485+
"./fonts/embed": {
486+
"source": "./src/fonts/deterministicFonts.ts",
487+
"runtime": "./dist/fonts/deterministicFonts.js",
488+
"types": "./dist/fonts/deterministicFonts.d.ts",
489+
"environments": ["bun", "node"]
490+
},
491+
"./fonts/embedded-data": {
492+
"source": "./src/fonts/fontData.generated.ts",
493+
"runtime": "./dist/fonts/fontData.generated.js",
494+
"types": "./dist/fonts/fontData.generated.d.ts",
495+
"environments": ["bun", "node"]
496+
},
485497
"./figma": {
486498
"source": "./src/figma/index.ts",
487499
"runtime": "./dist/figma/index.js",

‎packages/core/package.json‎

Lines changed: 42 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -491,6 +491,18 @@
491491
"import": "./src/fonts/systemFontLocator.ts",
492492
"types": "./src/fonts/systemFontLocator.ts"
493493
},
494+
"./fonts/embed": {
495+
"bun": "./src/fonts/deterministicFonts.ts",
496+
"node": "./dist/fonts/deterministicFonts.js",
497+
"import": "./src/fonts/deterministicFonts.ts",
498+
"types": "./src/fonts/deterministicFonts.ts"
499+
},
500+
"./fonts/embedded-data": {
501+
"bun": "./src/fonts/fontData.generated.ts",
502+
"node": "./dist/fonts/fontData.generated.js",
503+
"import": "./src/fonts/fontData.generated.ts",
504+
"types": "./src/fonts/fontData.generated.ts"
505+
},
494506
"./figma": {
495507
"bun": "./src/figma/index.ts",
496508
"node": "./dist/figma/index.js",
@@ -817,6 +829,14 @@
817829
"import": "./dist/fonts/systemFontLocator.js",
818830
"types": "./dist/fonts/systemFontLocator.d.ts"
819831
},
832+
"./fonts/embed": {
833+
"import": "./dist/fonts/deterministicFonts.js",
834+
"types": "./dist/fonts/deterministicFonts.d.ts"
835+
},
836+
"./fonts/embedded-data": {
837+
"import": "./dist/fonts/fontData.generated.js",
838+
"types": "./dist/fonts/fontData.generated.d.ts"
839+
},
820840
"./figma": {
821841
"import": "./dist/figma/index.js",
822842
"types": "./dist/figma/index.d.ts"
@@ -828,7 +848,8 @@
828848
"types": "./dist/index.d.ts"
829849
},
830850
"scripts": {
831-
"build": "bun run build:hyperframes-runtime && bun run build:position-edits-render && bun run build:audio-fx-runtime && tsc && tsx scripts/rewrite-esm-extensions.ts",
851+
"build": "bun run build:fonts && bun run build:hyperframes-runtime && bun run build:position-edits-render && bun run build:audio-fx-runtime && tsc && tsx scripts/rewrite-esm-extensions.ts",
852+
"build:fonts": "node scripts/build-fonts.mjs",
832853
"test": "bun run check:position-edits-render && bun run build:audio-fx-runtime && vitest run",
833854
"test:watch": "vitest",
834855
"test:coverage": "vitest run --coverage",
@@ -861,9 +882,28 @@
861882
"@hyperframes/studio-server": "workspace:*",
862883
"bpm-detective": "^2.0.5",
863884
"linkedom": "^0.18.12",
864-
"postcss": "^8.5.8"
885+
"postcss": "^8.5.8",
886+
"wawoff2": "^2.0.1"
865887
},
866888
"devDependencies": {
889+
"@fontsource/archivo-black": "^5.2.8",
890+
"@fontsource/eb-garamond": "^5.2.7",
891+
"@fontsource/ibm-plex-mono": "^5.2.7",
892+
"@fontsource/inter": "^5.2.8",
893+
"@fontsource/jetbrains-mono": "^5.2.8",
894+
"@fontsource/lato": "^5.2.7",
895+
"@fontsource/league-gothic": "^5.2.8",
896+
"@fontsource/montserrat": "^5.2.8",
897+
"@fontsource/noto-sans-jp": "^5.2.9",
898+
"@fontsource/nunito": "^5.2.7",
899+
"@fontsource/open-sans": "^5.2.7",
900+
"@fontsource/oswald": "^5.2.8",
901+
"@fontsource/outfit": "^5.2.8",
902+
"@fontsource/playfair-display": "^5.2.8",
903+
"@fontsource/poppins": "^5.2.7",
904+
"@fontsource/roboto": "^5.2.10",
905+
"@fontsource/source-code-pro": "^5.2.7",
906+
"@fontsource/space-mono": "^5.2.9",
867907
"@types/jsdom": "^28.0.0",
868908
"@types/node": "^25.0.10",
869909
"@vitest/coverage-v8": "^4.1.11",
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
import { existsSync } from "node:fs";
33
import { execSync } from "node:child_process";
44

5-
const target = "src/services/fontData.generated.ts";
5+
const target = "src/fonts/fontData.generated.ts";
66

77
if (existsSync(target)) {
88
console.log("[build:fonts] skipped — fontData.generated.ts already exists");

0 commit comments

Comments
 (0)