@@ -15,7 +15,8 @@ const hooks = vi.hoisted(() => {
1515 failDecode : boolean ;
1616 failWrite : boolean ;
1717 failRename : boolean ;
18- } = { failDecode : false , failWrite : false , failRename : false } ;
18+ failCleanup : boolean ;
19+ } = { failDecode : false , failWrite : false , failRename : false , failCleanup : false } ;
1920 return state ;
2021} ) ;
2122vi . mock ( "node:child_process" , async ( ) => {
@@ -46,6 +47,10 @@ vi.mock("node:fs", async (importOriginal) => {
4647 }
4748 return fs . writeFileSync ( ...args ) ;
4849 } ,
50+ rmSync : ( ...args : Parameters < typeof fs . rmSync > ) => {
51+ if ( hooks . failCleanup ) throw new Error ( "cache cleanup failed" ) ;
52+ return fs . rmSync ( ...args ) ;
53+ } ,
4954 renameSync : ( ...args : Parameters < typeof fs . renameSync > ) => {
5055 if ( hooks . failRename ) throw new Error ( "cache rename failed" ) ;
5156 return fs . renameSync ( ...args ) ;
@@ -66,6 +71,7 @@ beforeEach(() => {
6671 failDecode : false ,
6772 failWrite : false ,
6873 failRename : false ,
74+ failCleanup : false ,
6975 } ) ;
7076 projectDir = fs . mkdtempSync ( join ( tmpdir ( ) , "hf-waveform-test-" ) ) ;
7177 fs . writeFileSync ( join ( projectDir , "audio.wav" ) , "audio" ) ;
@@ -128,6 +134,52 @@ for (const caller of ["helper", "route"]) {
128134 } ,
129135 ) ;
130136
137+ it . each ( [ true , false ] ) (
138+ "rejects a cache-directory symlink (target exists: %s)" ,
139+ async ( exists ) => {
140+ const outside = fs . mkdtempSync ( join ( tmpdir ( ) , "hf-waveform-outside-" ) ) ;
141+ const target = join ( outside , "cache" ) ;
142+ const outsideCache = join (
143+ target ,
144+ buildWaveformCacheKey ( "audio.wav" , fs . statSync ( join ( projectDir , "audio.wav" ) ) ) ,
145+ ) ;
146+ if ( exists ) {
147+ fs . mkdirSync ( target ) ;
148+ fs . writeFileSync ( outsideCache , "untouched" ) ;
149+ }
150+ fs . symlinkSync ( target , cacheDir , process . platform === "win32" ? "junction" : "dir" ) ;
151+ try {
152+ if ( caller === "helper" )
153+ await expect ( generateWaveformCache ( projectDir , "audio.wav" ) ) . rejects . toThrow ( ) ;
154+ else {
155+ const response = await request ( ) ;
156+ expect ( response . status ) . toBe ( 200 ) ;
157+ expect ( ( await response . json ( ) ) . peaks ) . toHaveLength ( 4000 ) ;
158+ }
159+ if ( exists ) {
160+ expect ( fs . readFileSync ( outsideCache , "utf8" ) ) . toBe ( "untouched" ) ;
161+ expect ( fs . readdirSync ( target ) ) . toHaveLength ( 1 ) ;
162+ } else expect ( fs . existsSync ( target ) ) . toBe ( false ) ;
163+ } finally {
164+ fs . rmSync ( outside , { recursive : true , force : true } ) ;
165+ }
166+ } ,
167+ ) ;
168+
169+ it ( "rejects a cache-directory symlink planted during decoding" , async ( ) => {
170+ const outside = fs . mkdtempSync ( join ( tmpdir ( ) , "hf-waveform-outside-" ) ) ;
171+ hooks . decode = ( ) =>
172+ fs . symlinkSync ( outside , cacheDir , process . platform === "win32" ? "junction" : "dir" ) ;
173+ try {
174+ if ( caller === "helper" )
175+ await expect ( generateWaveformCache ( projectDir , "audio.wav" ) ) . rejects . toThrow ( ) ;
176+ else expect ( ( await request ( ) ) . status ) . toBe ( 200 ) ;
177+ expect ( fs . readdirSync ( outside ) ) . toEqual ( [ ] ) ;
178+ } finally {
179+ fs . rmSync ( outside , { recursive : true , force : true } ) ;
180+ }
181+ } ) ;
182+
131183 it ( "reuses an existing cache without decoding" , async ( ) => {
132184 seedCache ( "[0.25,1]" ) ;
133185 await generate ( ) ;
@@ -202,3 +254,17 @@ it("keeps helper skipping, route 404s and decode failures unchanged", async () =
202254 expect ( ( await request ( ) ) . status ) . toBe ( 404 ) ;
203255 expect ( fs . existsSync ( cacheDir ) ) . toBe ( false ) ;
204256} ) ;
257+
258+ it ( "cleanup failure does not turn a successful publication into a helper error" , async ( ) => {
259+ hooks . failCleanup = true ;
260+ await expect ( generateWaveformCache ( projectDir , "audio.wav" ) ) . resolves . toBeUndefined ( ) ;
261+ expect ( readPeaks ( ) ) . toHaveLength ( 4000 ) ;
262+ } ) ;
263+ it ( "cleanup failure does not mask the original write error" , async ( ) => {
264+ hooks . failWrite = true ;
265+ hooks . failCleanup = true ;
266+ await expect ( generateWaveformCache ( projectDir , "audio.wav" ) ) . rejects . toThrow (
267+ "cache write failed" ,
268+ ) ;
269+ expect ( fs . existsSync ( cachePath ) ) . toBe ( false ) ;
270+ } ) ;
0 commit comments