Skip to content

Commit 9fc1c2f

Browse files
committed
fix(producer): verify sequential disk drawElement samples too
1 parent ec791e9 commit 9fc1c2f

3 files changed

Lines changed: 21 additions & 1 deletion

File tree

‎packages/engine/src/index.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -210,6 +210,7 @@ export {
210210
calculateOptimalWorkers,
211211
computeWorkerSizing,
212212
selectVerifySampleIndicesForTask,
213+
verifyDiskDrawElementSamples,
213214
distributeFrames,
214215
distributeFramesInterleaved,
215216
executeParallelCapture,

‎packages/engine/src/services/parallelCoordinator.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -646,7 +646,7 @@ async function psnrForDiskSample(
646646
// per-sample skip/breach) — already decomposed into psnrForDiskSample +
647647
// assertDiskSampleAboveFloor; further splitting obscures the check.
648648
// fallow-ignore-next-line complexity
649-
async function verifyDiskDrawElementSamples(
649+
export async function verifyDiskDrawElementSamples(
650650
session: CaptureSession,
651651
task: WorkerTask,
652652
streaming: boolean,

‎packages/producer/src/services/render/stages/captureStage.ts‎

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ import {
4444
type EngineConfig,
4545
captureFrame,
4646
captureFrameToBufferPipelined,
47+
verifyDiskDrawElementSamples,
4748
writeCapturedFrame,
4849
closeCaptureSession,
4950
completeDeferredDrawElementInit,
@@ -331,6 +332,24 @@ export async function runCaptureStage(input: CaptureStageInput): Promise<Capture
331332
reportFrame(i);
332333
}
333334
}
335+
// Sequential disk drawElement self-verification (PRINFRA-352 follow-up):
336+
// the sequential disk path — reachable under the explicit fast-capture
337+
// opt-in, including via probe-session reuse — armed ground-truth samples
338+
// but never checked them, exactly like the parallel disk workers before
339+
// #2749. Same synthetic-task shape the parallel verify uses; a breach
340+
// throws DrawElementVerificationError and the orchestrator's disk-stage
341+
// retry re-renders via screenshot.
342+
await verifyDiskDrawElementSamples(
343+
session,
344+
{
345+
workerId: 0,
346+
startFrame: rangeStart,
347+
endFrame: rangeEnd,
348+
outputDir: framesDir,
349+
outputFrameOffset: rangeStart,
350+
},
351+
false,
352+
);
334353
// Capture the sequential session's static-dedup perf before close (the
335354
// counters are valid only while the session is live).
336355
dedupPerfs.push(getCapturePerfSummary(session));

0 commit comments

Comments
 (0)