Repository navigation
Commit 91f1495
authored
fix(core): stop a graded plate painting through an inactive clip (#3196)
A color-graded image or video inside a timed sub-composition kept painting
after its clip window closed. The runtime hid the sub-composition wrapper with
`visibility: hidden`, but the grading canvas carried an explicit inline
`visibility: visible`, and an explicit value on a descendant escapes an
ancestor's inherited `hidden`. The treated plate composited over whichever
scene was actually on screen, in preview and in the encoded render alike.
`drawEntry` only refreshed its cached view of the source's visibility inside
`if (injectedFrameSource || !hiddenByColorGrading)`. That gate exists for
opacity: `hideSourceElement` sets `opacity: 0 !important` on the source while
grading is active, so mirroring the source's computed opacity onto the canvas
would blank it. Visibility was swept into the same gate by accident. Grading
never writes `visibility`, so the source's computed visibility always tracks
the clip window — and because every graded source is hidden-by-grading, the
mirror could never self-heal once it went stale.
Split the two mirrors: opacity stays gated, visibility is re-read from computed
style every frame. Deriving it from the source rather than from a notification
means any way of hiding a clip works, including ones that do not exist yet.1 parent c9dd841 commit 91f1495
2 files changed
Lines changed: 39 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
770 | 770 | | |
771 | 771 | | |
772 | 772 | | |
| 773 | + | |
| 774 | + | |
| 775 | + | |
| 776 | + | |
| 777 | + | |
| 778 | + | |
| 779 | + | |
| 780 | + | |
| 781 | + | |
| 782 | + | |
| 783 | + | |
| 784 | + | |
| 785 | + | |
| 786 | + | |
| 787 | + | |
| 788 | + | |
| 789 | + | |
| 790 | + | |
| 791 | + | |
| 792 | + | |
| 793 | + | |
| 794 | + | |
| 795 | + | |
| 796 | + | |
| 797 | + | |
| 798 | + | |
| 799 | + | |
| 800 | + | |
| 801 | + | |
773 | 802 | | |
774 | 803 | | |
775 | 804 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3065 | 3065 | | |
3066 | 3066 | | |
3067 | 3067 | | |
| 3068 | + | |
| 3069 | + | |
| 3070 | + | |
| 3071 | + | |
| 3072 | + | |
| 3073 | + | |
| 3074 | + | |
| 3075 | + | |
3068 | 3076 | | |
3069 | | - | |
3070 | 3077 | | |
3071 | | - | |
3072 | | - | |
3073 | 3078 | | |
| 3079 | + | |
| 3080 | + | |
3074 | 3081 | | |
3075 | 3082 | | |
3076 | 3083 | | |
| |||
0 commit comments