Skip to content

Commit 8d80530

Browse files
authored
fix(player): authenticate slideshow navigation senders (#3820)
* fix(player): authenticate slideshow navigation senders * test: isolate playground message boundary imports
1 parent c6010f2 commit 8d80530

3 files changed

Lines changed: 35 additions & 5 deletions

File tree

‎packages/player/src/slideshow/hyperframes-slideshow.test.ts‎

Lines changed: 29 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -199,6 +199,30 @@ describe("<hyperframes-slideshow>", () => {
199199
el.remove();
200200
});
201201

202+
it("accepts embedding-parent and self navigation but rejects other senders", () => {
203+
const onNext = vi.fn();
204+
const el = makeEl({ onNext });
205+
const embedding = document.createElement("iframe");
206+
const foreign = document.createElement("iframe");
207+
document.body.append(embedding, foreign);
208+
vi.stubGlobal("parent", embedding.contentWindow);
209+
try {
210+
for (const source of [foreign.contentWindow, null]) {
211+
window.dispatchEvent(new MessageEvent("message", { source, data: { type: "next" } }));
212+
}
213+
expect(onNext).not.toHaveBeenCalled();
214+
for (const source of [window, embedding.contentWindow]) {
215+
window.dispatchEvent(new MessageEvent("message", { source, data: { type: "next" } }));
216+
}
217+
expect(onNext).toHaveBeenCalledTimes(2);
218+
} finally {
219+
vi.unstubAllGlobals();
220+
embedding.remove();
221+
foreign.remove();
222+
el.remove();
223+
}
224+
});
225+
202226
it("handles postMessage next", () => {
203227
const el = document.createElement("hyperframes-slideshow") as any;
204228
document.body.appendChild(el);
@@ -215,7 +239,7 @@ describe("<hyperframes-slideshow>", () => {
215239
currentSlide: { hotspots: [] },
216240
nextSlide: null,
217241
});
218-
window.dispatchEvent(new MessageEvent("message", { data: { type: "next" } }));
242+
window.dispatchEvent(new MessageEvent("message", { source: window, data: { type: "next" } }));
219243
expect(nextCalled).toBe(true);
220244
el.remove();
221245
});
@@ -1981,7 +2005,7 @@ describe("<hyperframes-slideshow> Fix 7 — audience mode ignores window postMes
19812005
currentSlide: { hotspots: [] },
19822006
nextSlide: null,
19832007
});
1984-
window.dispatchEvent(new MessageEvent("message", { data: { type: "next" } }));
2008+
window.dispatchEvent(new MessageEvent("message", { source: window, data: { type: "next" } }));
19852009
expect(nextCalled).toBe(false);
19862010
el.remove();
19872011
});
@@ -2003,7 +2027,7 @@ describe("<hyperframes-slideshow> Fix 7 — audience mode ignores window postMes
20032027
currentSlide: { hotspots: [] },
20042028
nextSlide: null,
20052029
});
2006-
window.dispatchEvent(new MessageEvent("message", { data: { type: "next" } }));
2030+
window.dispatchEvent(new MessageEvent("message", { source: window, data: { type: "next" } }));
20072031
expect(nextCalled).toBe(true);
20082032
el.remove();
20092033
});
@@ -2474,7 +2498,7 @@ describe("<hyperframes-slideshow> Fix 4 — back affordance (postMessage only; c
24742498
backCalled = true;
24752499
},
24762500
});
2477-
window.dispatchEvent(new MessageEvent("message", { data: { type: "back" } }));
2501+
window.dispatchEvent(new MessageEvent("message", { source: window, data: { type: "back" } }));
24782502
expect(backCalled).toBe(true);
24792503
el.remove();
24802504
});
@@ -2488,7 +2512,7 @@ describe("<hyperframes-slideshow> Fix 4 — back affordance (postMessage only; c
24882512
},
24892513
});
24902514
el.setAttribute("mode", "audience");
2491-
window.dispatchEvent(new MessageEvent("message", { data: { type: "back" } }));
2515+
window.dispatchEvent(new MessageEvent("message", { source: window, data: { type: "back" } }));
24922516
expect(backCalled).toBe(false);
24932517
el.remove();
24942518
});

‎packages/player/src/slideshow/hyperframes-slideshow.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -914,6 +914,7 @@ export class HyperframesSlideshow extends HTMLElement {
914914

915915
// fallow-ignore-next-line complexity
916916
private onMessage = (e: MessageEvent): void => {
917+
if (e.source !== window.parent && e.source !== window) return;
917918
// Audience mode is driven by BroadcastChannel; ignore embed postMessage nav.
918919
if (this.resolveMode() === "audience") return;
919920
const data = e.data as { type?: unknown; slideIndex?: unknown } | null;

‎packages/sdk-playground/src/main.test.ts‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,11 @@ import { expect, it, vi } from "vitest";
44

55
// Keep initialization at the asynchronous persistence boundary while exercising
66
// the real static UI and its registered message listener.
7+
// The paused initializer never opens a composition. Keep unrelated SDK/parser
8+
// and raw animation-library transforms out of this message-boundary witness.
9+
vi.mock("@hyperframes/sdk", () => ({ openComposition: vi.fn() }));
10+
vi.mock("@hyperframes/core/gsap-parser-acorn", () => ({ parseGsapScriptAcorn: vi.fn() }));
11+
vi.mock("gsap/dist/gsap.min.js?raw", () => ({ default: "" }));
712
vi.mock("./fileAdapter.js", () => ({
813
createFileAdapter: () => new Promise(() => {}),
914
}));

0 commit comments

Comments
 (0)